Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using NUnit.Framework;
using NUnit.Framework;
using UITest.Appium;
using UITest.Core;

Expand All @@ -19,6 +19,11 @@ public void TextInEditorShouldScroll()
_ = App.WaitForElement("editor");
App.ScrollDown("editor");

#if MACCATALYST // In Catalyst scroll down is not effective so here we retry one more time to address the flakyness.
Thread.Sleep(500);
App.ScrollDown("editor");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modifying the swipePercentage parameter helps to fix the problem?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsuarezruiz, This test failure is not due to the swipe area percentage. In the failure scenario, the swipe action did not initiate at all. Therefore, we have implemented a retry mechanism instead of increasing the swipe percentage. Please let me know if you still have any concerns regarding this approach.

#endif

// The test passes if the text inside the editor scrolls down
VerifyScreenshot();
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,12 @@ public void VerifyEntryClearButtonVisibilitySetToWhileEditing()
App.DismissKeyboard();
}
#endif

#if IOS //Inconsistent keyboard visibility issue in iOS CI environments can cause test flakiness. As this test validate the clear button visibility only, so the keyboard is not mandatory.
VerifyScreenshot(cropBottom: 1200);
#else
VerifyScreenshot();
#endif
}

[Test]
Expand All @@ -45,7 +50,12 @@ public void VerifyEntryClearButtonVisibilitySetToNever()
App.DismissKeyboard();
}
#endif

#if IOS //Inconsistent keyboard visibility issue in iOS CI environments can cause test flakiness. As this test validate the clear button visibility only, so the keyboard is not mandatory.
VerifyScreenshot(cropBottom: 1200);
#else
VerifyScreenshot();
#endif
}
}
}
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading