Add ISearchBar handler and implement Text #450

rogihee · 2021-03-07T14:05:59Z

Description of Change

Implements #397

Additions made

Add ISearchBar interface that extends IView and IText
Adds Text property map to SearchBarHandler
Adds Text mapping methods to SearchBarHandler for Android and iOS
Adds extension methods to apply Text on Android/iOS
Adds PortHandler to renderers for UpdateText on Android/iOS
Adds DeviceTests for SearchBar.Text on iOS and Android

PR Checklist

mattleibow

Looking really good.

src/Core/src/Handlers/SearchBar/SearchBarHandler.Android.cs

mattleibow · 2021-03-07T15:34:09Z

/azp run

azure-pipelines · 2021-03-07T15:34:19Z

Azure Pipelines successfully started running 1 pipeline(s).

jsuarezruiz

Thanks for the PR, just small changes requested!.

src/Core/src/Core/ISearchBar.cs

jsuarezruiz · 2021-03-08T09:10:51Z

For more ISearchBar implementations xamarin/Xamarin.Forms#13524, could help!.

rmarinho · 2021-03-08T10:24:26Z

/azp run

azure-pipelines · 2021-03-08T10:24:37Z

Azure Pipelines successfully started running 1 pipeline(s).

mattleibow

Very nice! Besides the fact that ISearchBar needs to inherit from IText, this is good to go.

mattleibow · 2021-03-09T22:10:49Z

src/Core/src/Core/ISearchBar.cs

@@ -0,0 +1,7 @@
+namespace Microsoft.Maui
+{
+    public interface ISearchBar : IView


Should this maybe inherit from IText as well and not have the Text` property? For the additional properties, just let then exist and only add the mapping for text in this PR. The rest can be done later and we probably can and should re-use the code from Entry.

src/Core/src/Handlers/SearchBar/SearchBarHandler.Android.cs

Changed.

mattleibow

Based on the fact that views will get the various interfaces only once they get their properties, this looks good.

Just a note, ISearchBar should implement IText, but that will be done over a few PRs.

mattleibow · 2021-03-09T22:19:16Z

/azp run

azure-pipelines · 2021-03-09T22:19:27Z

Azure Pipelines successfully started running 1 pipeline(s).

jsuarezruiz

We need specific code to set the correct control size (by default, the entire container width), but we can include it in successive PRs.

mattleibow · 2021-03-10T18:49:43Z

/azp run

azure-pipelines · 2021-03-10T18:49:54Z

Azure Pipelines successfully started running 1 pipeline(s).

jsuarezruiz · 2021-03-11T09:44:34Z

/azp run

azure-pipelines · 2021-03-11T09:44:47Z

Azure Pipelines successfully started running 1 pipeline(s).

mattleibow · 2021-03-11T23:56:14Z

/azp run

azure-pipelines · 2021-03-11T23:56:25Z

Azure Pipelines successfully started running 1 pipeline(s).

jsuarezruiz · 2021-03-12T08:22:18Z

Thanks for the contribution!

* [Tizen] Add Resizetizer Tizen Implementation * Treat nullablity for buidling net6 project * Bump to latest and fix build error * Fix Tizen Handlers * Fix font and SingleProject to locate manifest * Update tizen manifest path * Bump to latest - Adds the GraphicsViewHandler and ShapeViewHandler - Apply one stop shop UseMauiControls (#1157) - Implements new APIs for each IView - and so on * Bump to latest - Including register images and set Compat Service Provider (#1306), and so on * [SingleProject] Update intermediate asset path * Bump to latest - Apply to start adding in APIs for adding legacy renderers via assembly scanning (#1333) - Update to IMauiContext (#1357) - and so on * Remove duplicate type for legacy compat renderers * Fix Color Extension * Adds Microsoft.Maui.Tizen.sln * Rebase to upstream latest main * InitialzationOption for MauiApp * Bump to latest - Apply to patch related to Animation (#1436) - Apply to register Microsoft.Maui.Graphics Platforms (#1441) - and so on. * Enable to DisplayResolutionUnit * Implement Clip * Implement ModalNavigationService * Update build targets for single project * Remove comment * Remove image resource on Tizen project * Remove space * Bump to latest - Added GestureManager.Tizen.cs (#1489) - Set handler to shimmed handler so it doesn't get reshimmed (#1483) - Turn XamlC on by default (#1422) - and so on * Fix SwitchHandler * Fix compatibility issue (#41) * Fix compatibility issue * Fix Compatibility Resource path * Fix Transformations (#42) * Fix the compat LayoutRenderer (#43) * Bump to latest - Modal Navigation Manager (#1563) - Implement the basic WindowHandler (#1468) - Don't extract native defaults, meaning users can no longer reset a color back to a platform theme (#1485) - Implement Alerts (Alert, Prompt and ActionSheet) (#1328) - And so on. * Fix Layout margin issue (#44) * [SingleProject] Fix Issues (#50) * Fix RefreshView related issue (#51) * Fix RefreshView related issue * Fix StreamImageSourceService.Tizen * Bumt to latest - Effects (#1574) - Improve Window and AnimationManager (#1653) - and so on * Add Microsoft.Maui.Graphics.Skia as PackageReference * Update Compatibility projects (*.csproj) for Tizen * Add AlertManager on Tizen (#57) * Add AlertManager on Tizen * Add null check and remove whitespace * Remove watch profile code * Change subscriber object * Add Essentials.Samples.Tizen (#24) * Add Essentials.Samples.Tizen * Add guard for null exception * Fix Essentials.Samples for Tizen * Fix csproj for net6 * Remove Forms.Init * Fix build error (#60) * Update referenced Tizen.UIExtensions version (#61) * Add BlazorWebView skeleton code (#62) * Bump to latest (#71) - Window lifecycle (#1754) - Move New Navigation Handler to Core and make it internal (#1800) - Scrollview handler (#1669) - ScrollView Resize + Window Handler Resize (#1676) - Font AutoScalingEnabled (#1774) - Rename Font Properties (#1755) - Update layout system to ensure native measure/arrange are called for all controls, even from Page subclasses (#1819) - IContainer as IList<IView> (#1724) - Implement Layout padding for new StackLayouts and GridLayout (#1749) - Delete all the TabIndex, TabStop, Focusable things! (#1777) - Introduce SetSemanticFocus API via SemanticExtensions (#1829) - Improve Window and AnimationManager (#1653) - And so on * Remove IPage on Tizen (#72) - Merge IFrameworkElement and IView and Remove IPage (#1875) * Remove obsolete methods from Controls (#73) - [Controls] Remove obsolete methods from Controls (#1644) * Fix issue related rebase (#74) * Add Blazor webview (#67) * Add Blazor webview * Replace space to tab * remove space * Fix AlertManager prompt layout issue (#76) * Fix entry cursor error (#68) * Fix entry cursor error * Update code referring to android extension * Remove duplicate code & Add exception cases * Code fixes for consistency * Fix nullable issue (#77) * Fix Image loading (#78) * Fix nested layout issue (#79) Co-authored-by: 허강호/Common Platform Lab(SR)/Principal Engineer/삼성전자 <kangho.hur@samsung.com> * Fix issues caused by bump up (#75) * Fix issues caused by bump up * Update Tizen file provider * Update file provider with proper path * Replace StackLayout from Compatibility.StackLayout (#82) * Fix unmatched partial method (#84) * Bump to latest * Fix GetDesiredSize (#87) * Fix GetDesiredSize * update for readability * Fix ScrollView content absolute position (#89) * Fixes incorrect parameter type for ILayoutManager.ArrangeChildren (Rectangle -> Size). (#91) * Make the HandlerToRendererShim simple * Revert "Fixes incorrect parameter type for ILayoutManager.ArrangeChildren (Rectangle -> Size). (#91)" (#97) This reverts commit c54ac83. * Add GestureManager (#96) * Add GestureManager * Fix DragGestureHandler * Fix GestureManager * Check nullable enable * Fix Label LineBreakMode using workaround (#98) * Refactor the LayoutHandler (#99) * Fix layout measure issue (#100) * Bump to latest * Fix LayoutHandler Update issue (#103) * Fix LayoutHandler Update issue * Implement InvalidateMeasure propagation * Update MapBackground * Fix default font size issue (#113) * Add InitializationOptions (#107) * Add InitializationOptions * Set UseSkiaSharp true as default * Apply DP as default * Fix SKClipperView to have proper size (#115) * Fix Essentials sample (#108) * Fix Essentials sample for Tizen * Remove UseSkiaSharp flag * Remove MaterialComponents * Fix Tizen flag * Remove CustomRenderer * Add ShellHandler (#64) * Add ShellHandler * Move ShellView into Platform/Tizen * Update ShellView * Move the code for embedded tizen resources to csproj * Add UIExtenstions for shell * fix ViewHandlerOfT dispose (#120) * MAUI workload for Tizen (#66) * Fix build and runtime error after bumping to latest code * Fix HandlerToRendererShim dispose (#127) * Add ShellSearchView (#121) * Add ShellSearchView * Fix the layout issue in ShellSearchResultList * Enable nullable * Fix maximum height of ShellSearchResultList * Fix scaling issue on Clip (#130) * Fix Shell build error on net6 project (#133) * Fix DisplayResolutionUnit sync issue (#134) * Fix build error (#137) * Replace SkiaGraphicsView with local patch (#135) This commit will be revert when upstream code is updated * Fix GraphicsView scaling issue (#136) * Support Min/Max Height/Width on IView and applying MauiApp/MauiAppBuilder pattern - Support Min/Max Height/Width on IView (#2265) - Updating .NET MAUI to use MauiApp/MauiAppBuilder pattern and use MS.Extensions.DependencyInjection (#2137) * Fix Tizen Templates (#144) * Fix webview break caused by updated dependency (#143) * Update the Tizen.UIExtension.ElmSharp version (#145) * Fix Essentials (#146) * Fix Essentials sample for tizen * Add SemanticScreenReader for Tizen * Fix Startup * Reomve internal UIExtensions compoments for Shell (#147) * Implement PlaceholderColor property in SearchBarHandlers - Implement PlaceholderColor property in SearchBarHandlers (#1512) * Adds missing implementation after bumping to latest main * Fix Control.Samples.Singleproject Main correctly (#150) * [Tizen] Add support for JS root components in BlazorWebView (#151) * [Tizen] Adds BoxView Handler * [Tizen] Update project templates to work with safe characters - Update project templates to work with safe characters (#2368) * [Tizen] Implement ProgressColor property in ProgressBarHandlers - Implement ProgressColor property in ProgressBarHandlers (#600) * [Tizen] Fix project template's tizne-manifest.xml correctly * [Tizen] Handle ContentViews and templated content in new layout system * [Tizen] WebView Handlers * [Tizen] Use Color.IsDefault in Compat renderers * Fix Essentials DeviceDisplay (#156) * Fix Essentials.DeviceDisplay * Fix DeviceDisplay * [Tizen] Fix build error on net6 * Fix Layout remove issue (#164) * Fix Layout remove issue * Fix layout remove on Dispose * Bump to latest (rc1) - ImageButtonHandler and Handler Re-usability (#2352) - Remove IBoxView (#2619) - Add SupportedOSPlatformVersion (#2565) - Merge all the .NET 6 projects/solutions (#2505) - Shadow Support (#570) - Add IndicatorView handler(#2038) * [Tizen] Initial Border control * [Tizen] Apply graphics related code review feedback * [Tizen] Remove Device.OpenUri impl and Device.Flags/SetFlags * [Tizen] Fix Display Prompt Alerts * [Tizen] Fix WebView Handler * [Tizen] Fix ShapeViewHandler * [Tizen] Port H/V TextAlignment to Editor/Picker Handler * [Tizen] Add TVShellView (#183) * [Tizen] Add TVShellView * [Tizen] Update TVShellView * [Tizen] Update NativeView for Shell * [Tizen] Update ShellView * [Tizen] Change default FlyoutBackgroundColor for TV * [Tizen] Enable nullable * Refactor WrapperView to draw drawable features (#186) * Refactor WrapperView to draw drawable features * Update class names and devide files * Override NeesContainer to remove duplicated code * Update class names * [Tizen] Adds ApplicationHandler * Remove dispose action on ImageSourceServiceResult (#192) * Fix Background issue of Frame (#193) * Fix UpdateBackground (#194) * Fix UpdateBackground * Add ContentView Background mapper * Fix Editor/Entry/Label/Layout Background * Add IWrapperViewCanvas.Content * Add PageHandler Background mapper * Restore WrapperView * Remove unnecessary namespace * [Tizen] Fix build error on PageHandler * [Tizen] Fix ButtonHandler events * [Tizen] Use new dispatcher instance in Tizen's BlazorWebView * [Tizen] Fix DpiPath correctly * [Tizen] Fix Compatibility and Controls.Sample build error * [Tizen] Initial CollectionViewHandler * [Tizen] Apply ITextButton related changes * [Tizen] Add Shadows (#233) * [Tizen] Add Shadows * [Tizen] Apply review comments * [Tizen] Move updating shape in proper position * [Tizen] Update BackgroundDrawable * [Tizen] Apply review comments * [Tizen] Add BorderDrawable (#224) * Move to platform specific * Fix border handler for Tizen * Rename ToDrawable method * Fix border content layout * Fix BorderView * Apply rebase * [Tizen] Fix entry cursor issue (#222) * Fix entry cursor issue * Fix UpdateSelectionLength method * [Tizen] Remove TVNavigationDrawer TVNavigationView (#223) * [Tizen] Remove TVNavigationDrawer TVNavigationView * [Elmsharp] Update Tizen.UIExtensions version * [Tizen] Remove Forms DeviceInfo and use Essentials * [Tizen] Initial Multi Window support * [Tizen] Fix MauiContext * [Tizen] Refactor Border by defining MauiDrawable (#248) * [Tizen] Refactor Border by defining MauiDrawable * [Tizen] Apply review comments * [Tizen] Remove unnecessary type casting * [Tizen] Move getting path logic to drawable * [Tizen] Obsolete AndExpand & Remove IsolatedStorage * Fix layout measure issue (#254) * Fix layout measure issue * Update src/Compatibility/Core/src/Tizen/Platform.cs Co-authored-by: 허강호/Common Platform Lab(SR)/Principal Engineer/삼성전자 <kangho.hur@samsung.com> Co-authored-by: 허강호/Common Platform Lab(SR)/Principal Engineer/삼성전자 <kangho.hur@samsung.com> * Fix tizen solution (.sln) correctly * [Tizen] Add VerticalTextAlignment * [Tizen] Move IDispatcher logic out of IPlatformServices * [Tizen] Fix Scoping of MauiContext * Fix NavigationPage navigating issue (#263) * [Tizen] Add ImageButton handler (#261) * [Tizen] Add ImageButton handler * Add comment * Fix Compatibility build error (#265) * Fix catch exception for sample (#262) * Fix catch exception for control sample * Fix exception type for Tizen * Add bracket * [Tizen] Use CoreApplication as native app type * Fix ScrollView (#269) * [Tizen] Add Collectionview adaptor (#271) * [Tizen] Add CollectionView Adaptors * Remove unnecessary override * Fix ConvertToScaledDP * Fix flag * Fix item selected event * Apply review comments * Move to extension for CollectionView * [Tizen] Remove legacy Log and use ILogger * [Tizen] Applying upstream changes * [Tizen] Add ContainerView to Layout if it's present * [Tizen] Initial Reloadyfy support * [Tizen] Initial IVisualDiagnosticOveraly support * [Tizen] Setup first set of Automation Properties * [Tizen] Move types in the Platform folder into the Platform namespaces * Fix CollectionView layout issue (#288) * Fix CollectionView layout issue * Remove unnecessary code * [Tizen] ZIndex proof-of-concept * Fix ScrollView ContentSize and Padding margin (#291) * Fix ScrollView ContentSize and Padding margin * Fix MapRequestScrollTo * Update src/Core/src/Handlers/ScrollView/ScrollViewHandler.Tizen.cs Co-authored-by: 허강호/Common Platform Lab(SR)/Principal Engineer/삼성전자 <kangho.hur@samsung.com> * Update src/Core/src/Handlers/ScrollView/ScrollViewHandler.Tizen.cs Co-authored-by: 허강호/Common Platform Lab(SR)/Principal Engineer/삼성전자 <kangho.hur@samsung.com> * Remove MapContentSize Co-authored-by: 허강호/Common Platform Lab(SR)/Principal Engineer/삼성전자 <kangho.hur@samsung.com> * Implements WindowOverlay and VisualDiagnosticsOverlay (#294) * Implements WindowOverlay and VisualDiagnosticsOverlay * Apply code review * [Tizen] Fix Image Handler * Remove GetDesiredSize (#295) * [Tizen] Fix ButtonHandler * Fix UpdateSemantics (#299) * Fix UpdateSemantics * Fix Semantics mapping * Apply comment * [Tizen] Organize and centralize HandlerExtensions * Refactor WrapperView and Fix Issue (#302) * Refactor WrapperView * Use Thickness type for Shadow margin * Update variable name * Update class name to GraphicsExtensions * Fix essentials sample for Tizen (#305) * [Tizen] Fix NativeView casting issue * [Tizen] Update the UIExtensions package version * [Templates] Update Tizen Template (#311) * [Tizen] Initial Flyout handler * Fix BlazorWebview binary resource issue (#317) * [Tizen] Handle query strings in Blazor static assets by trimming them out * Refactor MauiContext (#330) * [Tizen] Adds PaintExtensions * [Tizen] Update compat's Platform * [Tizen] Fix controls build error * [Tizen] Adds RadioButton Handler * [Tizen] Implement CursorPosition in IEditor/ITextInput Handlers * [Tizen] Initial SwipeView Handler * [Tizen] Remove GetNative * [Tizen] Update Microsoft.NET.Sdk.Maui/WorkloadManifest * [Tizen] Add FormattedText property support to Label in Controls * [Tizen] Bump to latest * [Tizen] Use legacy compat renderers temporarily * [Tizen] Use BorderView * [SingleProject] Update splash updator (#353) * [singleproject] update splash updator * [singleproject] update icon updator * [singleproject] Fix default icon path * [Tizen] Fix BlazorWebView build error (#355) * [Tizen] Fix BlazorWebView build error * [Tizen] Update tizen handler * [Tizen] Implement IPlatformApplication.Current * [Tizen] Implements missing WebViewHandler APIs * [Tizen] Refactor AppInfo/PhoneDialer into interface * [Tizen] Fix INativeViewHandler to return more expected NativeView * [Tizen] Remove legacy TFMs * [Tizen] Refactor DeviceInfo and Flashlight to use an interface * [Tizen] Remove `IPlatformInvalidate` and `Device.Invalidate() * [Tizen] Refactored Geocoding to an interface * [Tizen] Adds Microsoft.Maui.Graphics.Skia as package reference * [Tizen] Refactored Map, SMS, Contacts to an interface * [Tizen] Bump to latest * [Tizen] Fix Essential sample build error * [Tizen] Fix Workload build error * Add Platform code on Controls.Sample.Sandbox for tizen (#382) * Fix processing MauiAssets (#383) Co-authored-by: Jay Cho <chojoong@gmail.com> * [Tizen] Refactor Essential's implementations * [Tizen] Renaming public APIs Native -> Platform * [Tizen] Update template & sample's tizen-manifest.xml * Fix DotNet.csproj to build tizen (#372) * [Tizen] Update ImageHandler and ImageButtonHandler * [Tizen] Add handling for TextTransform for SearchBar/Editor/Entry * [Tizen] Interfaced Handler for Label, Page, NavigationView, Picker, ProgressBar, SwipeView * [Tizen] Initial MenuBar * [Tizen] Moved GetPlatformSize logic into a new service * [Tizen] Interfaced handler for Switch, TimePicker, WebView, Slider, SearchBar, RefreshView, RadioButton * [Tizen] Fix build error after rebasing * [Tizen] Use StringComparison.Ordinal everywhere * [Tizen] Move TabbedPageHandler to TabbedViewHandler * [Tizen] Add more APIs to IDispatcher * [Tizen] Remove Application.Properties implementation * [Tizen] Backport p14 changes * [Tizen] Implement InputTransparent * [Tizen] Loaded/Unloaded events and propagate Window * [Tizen] Fix Path shapes rendering issues * [Tizen] Fix CI build error on ImageButtonHandler * [Tizen] Optimize ConfigureFonts and Logging during startup * [Tizen] Make sure StrokeDashArray property invalidate the Shape * [Tizen] Implement FillRule property in Polygon/PolylineHandler * [Tizen] Add install tizen to provision.yml * [Tizen] Simplify OnPlatformExtension * [Tizen] Use interface on mappers of shapes * [Tizen] Install tizen workload on dotnet-local-workloads * [Tizen] Move package version into Versions.props * [Tizen] Move 'UseMauiApp' call into "Controls" * [Tizen] update template description of localized string files * [Tizen] Update the package reference of Microsoft.Maui.Dependencies * [Tizen] Add IWindow.DisplayDensity * [Tizen] Initial VisualDiagnostic Image APIs * [Tizen] Mark all the Device [Obsolete] * [Tizen] Mark renderers and related base classes as obsolete * [Tizen] Platform behavior implementation * [Tizen] Clean unnecessary resource files * [Tizen] Graphics events * [Tizen] Modernize Essentials Namepsaces * [Tizen] Fix Compat's control gallery build error * Fix ClipperView background color issue (#447) * Fix typo (#450) * [Tizen] Initial support for configuring the underlying Web view settings * [Tizen] BlazorWebView public API tracking * [Tizen] use latest tizen workload as default * [Tizen] specify sdk version to avoid ci build error * [Tizen] Keep the text wrapping/truncation and max lines stuff in Controls * [Tizen] Remove downcasts in BlazorWebView * [Tizen] BlazorWebView API review changes: Shared sources * [Tizen] add tizen TFM optional * [Tizen] adding informative comments for template * [Tizen] Set IncludeTizenTargetFrameworks correctly * [Tizen] install maui-tizen Co-authored-by: JoonghyunCho <jh5.cho@samsung.com> Co-authored-by: Seungkeun Lee <sngn.lee@samsung.com> Co-authored-by: 김성수/Common Platform Lab(SR)/Staff Engineer/삼성전자 <sung-su.kim@samsung.com> Co-authored-by: 박인서/Common Platform Lab(SR)/Associate/삼성전자 <inseo9.park@samsung.com> Co-authored-by: 민성현/Common Platform Lab(SR)/Staff Engineer/삼성전자 <shyun.min@samsung.com> Co-authored-by: Jay Cho <chojoong@gmail.com>

rogihee added 3 commits March 7, 2021 14:47

Port SearchBar.Text to Handler #397

d735dd0

Add PortHandler to UpdateText

f70d97a

Fix parameter name

0427d98

mattleibow reviewed Mar 7, 2021

View reviewed changes

src/Core/src/Handlers/SearchBar/SearchBarHandler.Android.cs Show resolved Hide resolved

mattleibow added this to In progress in Handler Property Backlog via automation Mar 7, 2021

rogihee and others added 2 commits March 7, 2021 16:50

Use AppCompat version of SearchView

06caf7c

Merge branch 'main' into main

8965cae

jsuarezruiz previously requested changes Mar 8, 2021

View reviewed changes

src/Core/src/Core/ISearchBar.cs Outdated Show resolved Hide resolved

Replace IText for Text property until we also have TextColor

67eceb8

rogihee requested a review from jsuarezruiz March 8, 2021 19:11

Merge branch 'main' into main

5b3126e

mattleibow previously requested changes Mar 9, 2021

View reviewed changes

mattleibow approved these changes Mar 9, 2021

View reviewed changes

Merge branch 'main' into main

d214b80

jsuarezruiz approved these changes Mar 10, 2021

View reviewed changes

Merge branch 'main' into main

6541480

hartez linked an issue Mar 10, 2021 that may be closed by this pull request

Port SearchBar.Text to Handler #397

Closed

jsuarezruiz added 2 commits March 11, 2021 09:07

Merge branch 'main' into main

e1465e0

Merge branch 'main' into main

e18c787

hartez and others added 4 commits March 11, 2021 13:57

Fix Android tests (cast to wrong type)

4b16db8

Merge remote-tracking branch 'origin/main' into pr/450

2e5e6b3

Formatting

4c80c82

Merge remote-tracking branch 'origin/main' into pr/450

4bff6f8

mattleibow approved these changes Mar 11, 2021

View reviewed changes

Merge branch 'main' into main

5231657

jsuarezruiz merged commit 81f2dca into dotnet:main Mar 12, 2021

Handler Property Backlog automation moved this from In progress to Done Mar 12, 2021

rookiejava pushed a commit to rookiejava/maui that referenced this pull request Apr 7, 2022

Fix typo (dotnet#450)

8b90c78

rookiejava pushed a commit to rookiejava/maui that referenced this pull request Apr 7, 2022

Fix typo (dotnet#450)

6c21b17

rookiejava pushed a commit to rookiejava/maui that referenced this pull request Apr 8, 2022

Fix typo (dotnet#450)

6b9e6cf

rookiejava pushed a commit to rookiejava/maui that referenced this pull request Apr 10, 2022

Fix typo (dotnet#450)

ca11209

rookiejava pushed a commit to rookiejava/maui that referenced this pull request Apr 11, 2022

Fix typo (dotnet#450)

8978350

rookiejava pushed a commit to rookiejava/maui that referenced this pull request Apr 11, 2022

Fix typo (dotnet#450)

288b450

rookiejava pushed a commit to rookiejava/maui that referenced this pull request Apr 12, 2022

Fix typo (dotnet#450)

7a8ecf1

rookiejava pushed a commit to rookiejava/maui that referenced this pull request Apr 13, 2022

Fix typo (dotnet#450)

b66d9ae

rookiejava pushed a commit to rookiejava/maui that referenced this pull request Apr 13, 2022

Fix typo (dotnet#450)

5fc87ba

rookiejava pushed a commit to rookiejava/maui that referenced this pull request Apr 14, 2022

Fix typo (dotnet#450)

82c2379

github-actions bot locked and limited conversation to collaborators Dec 27, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add ISearchBar handler and implement Text #450

Add ISearchBar handler and implement Text #450

rogihee commented Mar 7, 2021 •

edited

mattleibow left a comment

mattleibow commented Mar 7, 2021

azure-pipelines bot commented Mar 7, 2021

jsuarezruiz left a comment

jsuarezruiz commented Mar 8, 2021

rmarinho commented Mar 8, 2021

azure-pipelines bot commented Mar 8, 2021

mattleibow left a comment

mattleibow Mar 9, 2021

mattleibow left a comment

mattleibow commented Mar 9, 2021

azure-pipelines bot commented Mar 9, 2021

jsuarezruiz left a comment

mattleibow commented Mar 10, 2021

azure-pipelines bot commented Mar 10, 2021

jsuarezruiz commented Mar 11, 2021

azure-pipelines bot commented Mar 11, 2021

mattleibow commented Mar 11, 2021

azure-pipelines bot commented Mar 11, 2021

jsuarezruiz commented Mar 12, 2021

Add ISearchBar handler and implement Text #450

Add ISearchBar handler and implement Text #450

Conversation

rogihee commented Mar 7, 2021 • edited

Description of Change

Additions made

PR Checklist

mattleibow left a comment

Choose a reason for hiding this comment

mattleibow commented Mar 7, 2021

azure-pipelines bot commented Mar 7, 2021

jsuarezruiz left a comment

Choose a reason for hiding this comment

jsuarezruiz commented Mar 8, 2021

rmarinho commented Mar 8, 2021

azure-pipelines bot commented Mar 8, 2021

mattleibow left a comment

Choose a reason for hiding this comment

mattleibow Mar 9, 2021

Choose a reason for hiding this comment

mattleibow left a comment

Choose a reason for hiding this comment

mattleibow commented Mar 9, 2021

azure-pipelines bot commented Mar 9, 2021

jsuarezruiz left a comment

Choose a reason for hiding this comment

mattleibow commented Mar 10, 2021

azure-pipelines bot commented Mar 10, 2021

jsuarezruiz commented Mar 11, 2021

azure-pipelines bot commented Mar 11, 2021

mattleibow commented Mar 11, 2021

azure-pipelines bot commented Mar 11, 2021

jsuarezruiz commented Mar 12, 2021

rogihee commented Mar 7, 2021 •

edited