Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Controls] Remove obsolete methods from Controls #1644

Merged
merged 11 commits into from
Aug 2, 2021
Merged

[Controls] Remove obsolete methods from Controls #1644

merged 11 commits into from
Aug 2, 2021

Conversation

rmarinho
Copy link
Member

@rmarinho rmarinho commented Jul 12, 2021 •
edited
Loading

Description of Change

Remove obsolete usage on Maui.Controls

  • Remove usage of MasterDetailPage and MasterDetailPageRenderer
  • Remove GetSizeRequest and replace by Measure calls
  • Remove OnSizeRequest and replace by OnMeasure calls

Additions made

Add virtual modifier to VisualElement

  • public virtual SizeRequest Measure(double widthConstraint, double heightConstraint, MeasureFlags flags = MeasureFlags.None)

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)
  • Targets a single property for a single control (or intertwined few properties)
  • Adds the property to the appropriate interface
  • Avoids any changes not essential to the handler property
  • Adds the mapping to the PropertyMapper in the handler
  • Adds the mapping method to the Android, iOS, and Standard aspects of the handler
  • Implements the actual property updates (usually in extension methods in the Platform section of Core)
  • Tags ported renderer methods with [PortHandler]
  • Adds an example of the property to the sample project (MainPage)
  • Adds the property to the stub class
  • Implements basic property tests in DeviceTests

Does this PR touch anything that might affect accessibility?

  • Does this PR introduce a new control? (If yes, add an example using SemanticProperties to the SemanticsPage)
  • APIs that modify focusability?
  • APIs that modify any text property on a control?
  • Does this PR modify view nesting or view arrangement in anyway?
  • Is there the smallest possibility that your PR will change accessibility?
  • I'm not sure, please help me

If any of the above checkboxes apply to your PR, then the PR will need to provide testing to demonstrate that accessibility still works.

@rmarinho rmarinho changed the title [Controls] Remove absolete [Controls] Remove absolete from Controls Jul 12, 2021
@jsuarezruiz
Copy link
Contributor

This is the build error:
Compatibility\Core\src\WinUI\FlyoutPageRenderer.cs(202,28): error CS0103: The name 'Specifics' does not exist in the current context [D:\agent\1\s\src\Compatibility\Core\src\Compatibility-net6.csproj]

@rmarinho rmarinho requested review from PureWeen and hartez July 13, 2021 17:31
rmarinho
rmarinho commented Jul 14, 2021
View reviewed changes
src/Controls/src/Core/VisualElement.cs
@@ -783,7 +781,7 @@ public virtual SizeRequest GetSizeRequest(double widthConstraint, double heightC
return r;
}

public SizeRequest Measure(double widthConstraint, double heightConstraint, MeasureFlags flags = MeasureFlags.None)
public virtual SizeRequest Measure(double widthConstraint, double heightConstraint, MeasureFlags flags = MeasureFlags.None)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is one of the changes

@hartez hartez changed the title [Controls] Remove absolete from Controls [Controls] Remove obsolete methods from Controls Jul 15, 2021
jsuarezruiz
jsuarezruiz approved these changes Jul 16, 2021
View reviewed changes
Copy link
Contributor

@jsuarezruiz jsuarezruiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have launched the Gallery in emulators and everything looks correct.

@Redth Redth changed the base branch from release/6.0.1xx-preview6 to main July 21, 2021 12:18
@rmarinho rmarinho changed the base branch from main to release/6.0.1xx-preview7 August 2, 2021 11:17
mattleibow
mattleibow reviewed Aug 2, 2021
View reviewed changes
src/Compatibility/ControlGallery/src/Core/GalleryPages/TitleView.xaml
<Button Clicked="masterDetailsPage_Clicked" Text="Flyout Details Page"></Button>
<Button Clicked="masterDetailsPageIcon_Clicked" Text="Toggle MDP Icon"></Button>
<Button Clicked="flyoutPagesPage_Clicked" Text="Flyout Details Page"></Button>
<Button Clicked="flyoutPagesPageIcon_Clicked" Text="Toggle MDP Icon"></Button>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a couple of cases with MDP which should probably also go.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have alotttttt of them.. i think we keep it for now

src/Controls/src/Core/BoxView.cs
Comment on lines -39 to +37
protected override SizeRequest OnSizeRequest(double widthConstraint, double heightConstraint)
protected override SizeRequest OnMeasure(double widthConstraint, double heightConstraint)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hartez is this correct? I know this has been obsolete for years, but has it really been obsolete obsolete?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If not, now is it the time.

@Redth Redth added this to the 6.0.100-preview.7 milestone Aug 2, 2021
@PureWeen PureWeen merged commit fae6370 into release/6.0.1xx-preview7 Aug 2, 2021
@PureWeen PureWeen deleted the remove-absolete2 branch August 2, 2021 20:19
rookiejava added a commit to rookiejava/maui that referenced this pull request Aug 4, 2021
@rookiejava
Remove obsolete methods from Controls (#73)
442b5d1 
- [Controls] Remove obsolete methods from Controls (dotnet#1644)
rookiejava added a commit to rookiejava/maui that referenced this pull request Aug 4, 2021
@rookiejava
Remove obsolete methods from Controls (#73)
482fbdc 
- [Controls] Remove obsolete methods from Controls (dotnet#1644)
rookiejava added a commit to rookiejava/maui that referenced this pull request Apr 11, 2022
@rookiejava
Remove obsolete methods from Controls (#73)
7f036a5 
- [Controls] Remove obsolete methods from Controls (dotnet#1644)
rookiejava added a commit to rookiejava/maui that referenced this pull request Apr 12, 2022
@rookiejava
Remove obsolete methods from Controls (#73)
f15ebff 
- [Controls] Remove obsolete methods from Controls (dotnet#1644)
rookiejava added a commit to rookiejava/maui that referenced this pull request Apr 13, 2022
@rookiejava
Remove obsolete methods from Controls (#73)
ddf9ab4 
- [Controls] Remove obsolete methods from Controls (dotnet#1644)
rookiejava added a commit to rookiejava/maui that referenced this pull request Apr 13, 2022
@rookiejava
Remove obsolete methods from Controls (#73)
80103df 
- [Controls] Remove obsolete methods from Controls (dotnet#1644)
rookiejava added a commit to rookiejava/maui that referenced this pull request Apr 14, 2022
@rookiejava
Remove obsolete methods from Controls (#73)
8a02570 
- [Controls] Remove obsolete methods from Controls (dotnet#1644)
mattleibow pushed a commit that referenced this pull request Apr 15, 2022
@rookiejava @JoonghyunCho
@myroot @sung-su @shyunMin
Adds Tizen backend (#2360)
438aef2 
* [Tizen] Add Resizetizer Tizen Implementation

* Treat nullablity for buidling net6 project

* Bump to latest and fix build error

* Fix Tizen Handlers

* Fix font and SingleProject to locate manifest

* Update tizen manifest path

* Bump to latest

- Adds the GraphicsViewHandler and ShapeViewHandler
- Apply one stop shop UseMauiControls (#1157)
- Implements new APIs for each IView
- and so on

* Bump to latest

- Including register images and set Compat Service Provider (#1306), and so on

* [SingleProject] Update intermediate asset path

* Bump to latest

- Apply to start adding in APIs for adding legacy renderers via assembly scanning (#1333)
- Update to IMauiContext (#1357)
- and so on

* Remove duplicate type for legacy compat renderers

* Fix Color Extension

* Adds Microsoft.Maui.Tizen.sln

* Rebase to upstream latest main

* InitialzationOption for MauiApp

* Bump to latest

- Apply to patch related to Animation (#1436)
- Apply to register Microsoft.Maui.Graphics Platforms (#1441)
- and so on.

* Enable to DisplayResolutionUnit

* Implement Clip

* Implement ModalNavigationService

* Update build targets for single project

* Remove comment

* Remove image resource on Tizen project

* Remove space

* Bump to latest

- Added GestureManager.Tizen.cs (#1489)
- Set handler to shimmed handler so it doesn't get reshimmed  (#1483)
- Turn XamlC on by default (#1422)
- and so on

* Fix SwitchHandler

* Fix compatibility issue (#41)

* Fix compatibility issue

* Fix Compatibility Resource path

* Fix Transformations (#42)

* Fix the compat LayoutRenderer (#43)

* Bump to latest

- Modal Navigation Manager (#1563)
- Implement the basic WindowHandler (#1468)
- Don't extract native defaults, meaning users can no longer reset a color back to a platform theme (#1485)
- Implement Alerts (Alert, Prompt and ActionSheet) (#1328)
- And so on.

* Fix Layout margin issue (#44)

* [SingleProject] Fix Issues (#50)

* Fix RefreshView related issue (#51)

* Fix RefreshView related issue

* Fix StreamImageSourceService.Tizen

* Bumt to latest

- Effects (#1574)
- Improve Window and AnimationManager (#1653)
- and so on

* Add Microsoft.Maui.Graphics.Skia as PackageReference

* Update Compatibility projects (*.csproj) for Tizen

* Add AlertManager on Tizen (#57)

* Add AlertManager on Tizen

* Add null check and remove whitespace

* Remove watch profile code

* Change subscriber object

* Add Essentials.Samples.Tizen (#24)

* Add Essentials.Samples.Tizen

* Add guard for null exception

* Fix Essentials.Samples for Tizen

* Fix csproj for net6

* Remove Forms.Init

* Fix build error (#60)

* Update referenced Tizen.UIExtensions version (#61)

* Add BlazorWebView skeleton code (#62)

* Bump to latest (#71)

- Window lifecycle (#1754)
- Move New Navigation Handler to Core and make it internal (#1800)
- Scrollview handler (#1669)
- ScrollView Resize + Window Handler Resize (#1676)
- Font AutoScalingEnabled (#1774)
- Rename Font Properties (#1755)
- Update layout system to ensure native measure/arrange are called for all controls, even from Page subclasses (#1819)
- IContainer as IList<IView> (#1724)
- Implement Layout padding for new StackLayouts and GridLayout (#1749)
- Delete all the TabIndex, TabStop, Focusable things! (#1777)
- Introduce SetSemanticFocus API via SemanticExtensions (#1829)
- Improve Window and AnimationManager (#1653)
- And so on

* Remove IPage on Tizen (#72)

- Merge IFrameworkElement and IView and Remove IPage (#1875)

* Remove obsolete methods from Controls (#73)

- [Controls] Remove obsolete methods from Controls (#1644)

* Fix issue related rebase (#74)

* Add Blazor webview (#67)

* Add Blazor webview

* Replace space to tab

* remove space

* Fix AlertManager prompt layout issue (#76)

* Fix entry cursor error (#68)

* Fix entry cursor error

* Update code referring to android extension

* Remove duplicate code & Add exception cases

* Code fixes for consistency

* Fix nullable issue (#77)

* Fix Image loading (#78)

* Fix nested layout issue (#79)

Co-authored-by: 허강호/Common Platform Lab(SR)/Principal Engineer/삼성전자 <kangho.hur@samsung.com>

* Fix issues caused by bump up (#75)

* Fix issues caused by bump up

* Update Tizen file provider

* Update file provider with proper path

* Replace StackLayout from Compatibility.StackLayout (#82)

* Fix unmatched partial method (#84)

* Bump to latest

* Fix GetDesiredSize (#87)

* Fix GetDesiredSize

* update for readability

* Fix ScrollView content absolute position (#89)

* Fixes incorrect parameter type for ILayoutManager.ArrangeChildren (Rectangle -> Size). (#91)

* Make the HandlerToRendererShim simple

* Revert "Fixes incorrect parameter type for ILayoutManager.ArrangeChildren (Rectangle -> Size). (#91)" (#97)

This reverts commit c54ac83.

* Add GestureManager (#96)

* Add GestureManager

* Fix DragGestureHandler

* Fix GestureManager

* Check nullable enable

* Fix Label LineBreakMode using workaround (#98)

* Refactor the LayoutHandler (#99)

* Fix layout measure issue (#100)

* Bump to latest

* Fix LayoutHandler Update issue (#103)

* Fix LayoutHandler Update issue

* Implement InvalidateMeasure propagation

* Update MapBackground

* Fix default font size issue (#113)

* Add InitializationOptions (#107)

* Add InitializationOptions

* Set UseSkiaSharp true as default

* Apply DP as default

* Fix SKClipperView to have proper size (#115)

* Fix Essentials sample (#108)

* Fix Essentials sample for Tizen

* Remove UseSkiaSharp flag

* Remove MaterialComponents

* Fix Tizen flag

* Remove CustomRenderer

* Add ShellHandler (#64)

* Add ShellHandler

* Move ShellView into Platform/Tizen

* Update ShellView

* Move the code for embedded tizen resources to csproj

* Add UIExtenstions for shell

* fix ViewHandlerOfT dispose (#120)

* MAUI workload for Tizen (#66)

* Fix build and runtime error after bumping to latest code

* Fix HandlerToRendererShim dispose (#127)

* Add ShellSearchView (#121)

* Add ShellSearchView

* Fix the layout issue in ShellSearchResultList

* Enable nullable

* Fix maximum height of ShellSearchResultList

* Fix scaling issue on Clip (#130)

* Fix Shell build error on net6 project (#133)

* Fix DisplayResolutionUnit sync issue (#134)

* Fix build error (#137)

* Replace SkiaGraphicsView with local patch (#135)

This commit will be revert when upstream code is updated

* Fix GraphicsView scaling issue (#136)

* Support Min/Max Height/Width on IView and applying MauiApp/MauiAppBuilder pattern

- Support Min/Max Height/Width on IView (#2265)
- Updating .NET MAUI to use MauiApp/MauiAppBuilder pattern and use MS.Extensions.DependencyInjection (#2137)

* Fix Tizen Templates (#144)

* Fix webview break caused by updated dependency (#143)

* Update the Tizen.UIExtension.ElmSharp version (#145)

* Fix Essentials (#146)

* Fix Essentials sample for tizen

* Add SemanticScreenReader for Tizen

* Fix Startup

* Reomve internal UIExtensions compoments for Shell (#147)

* Implement PlaceholderColor property in SearchBarHandlers

- Implement PlaceholderColor property in SearchBarHandlers (#1512)

* Adds missing implementation after bumping to latest main

* Fix Control.Samples.Singleproject Main correctly (#150)

* [Tizen] Add support for JS root components in BlazorWebView (#151)

* [Tizen] Adds BoxView Handler

* [Tizen] Update project templates to work with safe characters

- Update project templates to work with safe characters (#2368)

* [Tizen] Implement ProgressColor property in ProgressBarHandlers

- Implement ProgressColor property in ProgressBarHandlers (#600)

* [Tizen] Fix project template's tizne-manifest.xml correctly

* [Tizen] Handle ContentViews and templated content in new layout system

* [Tizen] WebView Handlers

* [Tizen] Use Color.IsDefault in Compat renderers

* Fix Essentials DeviceDisplay (#156)

* Fix Essentials.DeviceDisplay

* Fix DeviceDisplay

* [Tizen] Fix build error on net6

* Fix Layout remove issue (#164)

* Fix Layout remove issue

* Fix layout remove on Dispose

* Bump to latest (rc1)

- ImageButtonHandler and Handler Re-usability (#2352)
- Remove IBoxView (#2619)
- Add SupportedOSPlatformVersion (#2565)
- Merge all the .NET 6 projects/solutions (#2505)
- Shadow Support (#570)
- Add IndicatorView handler(#2038)

* [Tizen] Initial Border control

* [Tizen] Apply graphics related code review feedback

* [Tizen] Remove Device.OpenUri impl and Device.Flags/SetFlags

* [Tizen] Fix Display Prompt Alerts

* [Tizen] Fix WebView Handler

* [Tizen] Fix ShapeViewHandler

* [Tizen] Port H/V TextAlignment to Editor/Picker Handler

* [Tizen] Add TVShellView (#183)

* [Tizen] Add TVShellView

* [Tizen] Update TVShellView

* [Tizen] Update NativeView for Shell

* [Tizen] Update ShellView

* [Tizen] Change default FlyoutBackgroundColor for TV

* [Tizen] Enable nullable

* Refactor WrapperView to draw drawable features (#186)

* Refactor WrapperView to draw drawable features

* Update class names and devide files

* Override NeesContainer to remove duplicated code

* Update class names

* [Tizen] Adds ApplicationHandler

* Remove dispose action on ImageSourceServiceResult (#192)

* Fix Background issue of Frame (#193)

* Fix UpdateBackground (#194)

* Fix UpdateBackground

* Add ContentView Background mapper

* Fix Editor/Entry/Label/Layout Background

* Add IWrapperViewCanvas.Content

* Add PageHandler Background mapper

* Restore WrapperView

* Remove unnecessary namespace

* [Tizen] Fix build error on PageHandler

* [Tizen] Fix ButtonHandler events

* [Tizen] Use new dispatcher instance in Tizen's BlazorWebView

* [Tizen] Fix DpiPath correctly

* [Tizen] Fix Compatibility and Controls.Sample build error

* [Tizen] Initial CollectionViewHandler

* [Tizen] Apply ITextButton related changes

* [Tizen] Add Shadows (#233)

* [Tizen] Add Shadows

* [Tizen] Apply review comments

* [Tizen] Move updating shape in proper position

* [Tizen] Update BackgroundDrawable

* [Tizen] Apply review comments

* [Tizen] Add BorderDrawable (#224)

* Move to platform specific

* Fix border handler for Tizen

* Rename ToDrawable method

* Fix border content layout

* Fix BorderView

* Apply rebase

* [Tizen] Fix entry cursor issue (#222)

* Fix entry cursor issue

* Fix UpdateSelectionLength method

* [Tizen] Remove TVNavigationDrawer TVNavigationView (#223)

* [Tizen] Remove TVNavigationDrawer TVNavigationView

* [Elmsharp] Update Tizen.UIExtensions version

* [Tizen] Remove Forms DeviceInfo and use Essentials

* [Tizen] Initial Multi Window support

* [Tizen] Fix MauiContext

* [Tizen] Refactor Border by defining MauiDrawable (#248)

* [Tizen] Refactor Border by defining MauiDrawable

* [Tizen] Apply review comments

* [Tizen] Remove unnecessary type casting

* [Tizen] Move getting path logic to drawable

* [Tizen] Obsolete AndExpand & Remove IsolatedStorage

* Fix layout measure issue (#254)

* Fix layout measure issue

* Update src/Compatibility/Core/src/Tizen/Platform.cs

Co-authored-by: 허강호/Common Platform Lab(SR)/Principal Engineer/삼성전자 <kangho.hur@samsung.com>

Co-authored-by: 허강호/Common Platform Lab(SR)/Principal Engineer/삼성전자 <kangho.hur@samsung.com>

* Fix tizen solution (.sln) correctly

* [Tizen] Add VerticalTextAlignment

* [Tizen] Move IDispatcher logic out of IPlatformServices

* [Tizen] Fix Scoping of MauiContext

* Fix NavigationPage navigating issue (#263)

* [Tizen] Add ImageButton handler (#261)

* [Tizen] Add ImageButton handler

* Add comment

* Fix Compatibility build error (#265)

* Fix catch exception for sample (#262)

* Fix catch exception for control sample

* Fix exception type for Tizen

* Add bracket

* [Tizen] Use CoreApplication as native app type

* Fix ScrollView (#269)

* [Tizen] Add Collectionview adaptor (#271)

* [Tizen] Add CollectionView Adaptors

* Remove unnecessary override

* Fix ConvertToScaledDP

* Fix flag

* Fix item selected event

* Apply review comments

* Move to extension for CollectionView

* [Tizen] Remove legacy Log and use ILogger

* [Tizen] Applying upstream changes

* [Tizen] Add ContainerView to Layout if it's present

* [Tizen] Initial Reloadyfy support

* [Tizen] Initial IVisualDiagnosticOveraly support

* [Tizen] Setup first set of Automation Properties

* [Tizen] Move types in the Platform folder into the Platform namespaces

* Fix CollectionView layout issue (#288)

* Fix CollectionView layout issue

* Remove unnecessary code

* [Tizen] ZIndex proof-of-concept

* Fix ScrollView ContentSize and Padding margin (#291)

* Fix ScrollView ContentSize and Padding margin

* Fix MapRequestScrollTo

* Update src/Core/src/Handlers/ScrollView/ScrollViewHandler.Tizen.cs

Co-authored-by: 허강호/Common Platform Lab(SR)/Principal Engineer/삼성전자 <kangho.hur@samsung.com>

* Update src/Core/src/Handlers/ScrollView/ScrollViewHandler.Tizen.cs

Co-authored-by: 허강호/Common Platform Lab(SR)/Principal Engineer/삼성전자 <kangho.hur@samsung.com>

* Remove MapContentSize

Co-authored-by: 허강호/Common Platform Lab(SR)/Principal Engineer/삼성전자 <kangho.hur@samsung.com>

* Implements WindowOverlay and VisualDiagnosticsOverlay (#294)

* Implements WindowOverlay and VisualDiagnosticsOverlay

* Apply code review

* [Tizen] Fix Image Handler

* Remove GetDesiredSize (#295)

* [Tizen] Fix ButtonHandler

* Fix UpdateSemantics (#299)

* Fix UpdateSemantics

* Fix Semantics mapping

* Apply comment

* [Tizen] Organize and centralize HandlerExtensions

* Refactor WrapperView and Fix Issue (#302)

* Refactor WrapperView

* Use Thickness type for Shadow margin

* Update variable name

* Update class name to GraphicsExtensions

* Fix essentials sample for Tizen (#305)

* [Tizen] Fix NativeView casting issue

* [Tizen] Update the UIExtensions package version

* [Templates] Update Tizen Template (#311)

* [Tizen] Initial Flyout handler

* Fix BlazorWebview binary resource issue (#317)

* [Tizen] Handle query strings in Blazor static assets by trimming them out

* Refactor MauiContext (#330)

* [Tizen] Adds PaintExtensions

* [Tizen] Update compat's Platform

* [Tizen] Fix controls build error

* [Tizen] Adds RadioButton Handler

* [Tizen] Implement CursorPosition in IEditor/ITextInput Handlers

* [Tizen] Initial SwipeView Handler

* [Tizen] Remove GetNative

* [Tizen] Update Microsoft.NET.Sdk.Maui/WorkloadManifest

* [Tizen] Add FormattedText property support to Label in Controls

* [Tizen] Bump to latest

* [Tizen] Use legacy compat renderers temporarily

* [Tizen] Use BorderView

* [SingleProject] Update splash updator (#353)

* [singleproject] update splash updator

* [singleproject] update icon updator

* [singleproject] Fix default icon path

* [Tizen] Fix BlazorWebView build error (#355)

* [Tizen] Fix BlazorWebView build error

* [Tizen] Update tizen handler

* [Tizen] Implement IPlatformApplication.Current

* [Tizen] Implements missing WebViewHandler APIs

* [Tizen] Refactor AppInfo/PhoneDialer into interface

* [Tizen] Fix INativeViewHandler to return more expected NativeView

* [Tizen] Remove legacy TFMs

* [Tizen] Refactor DeviceInfo and Flashlight to use an interface

* [Tizen] Remove `IPlatformInvalidate` and `Device.Invalidate()

* [Tizen] Refactored Geocoding to an interface

* [Tizen] Adds Microsoft.Maui.Graphics.Skia as package reference

* [Tizen] Refactored Map, SMS, Contacts to an interface

* [Tizen] Bump to latest

* [Tizen] Fix Essential sample build error

* [Tizen] Fix Workload build error

* Add Platform code on Controls.Sample.Sandbox for tizen (#382)

* Fix processing MauiAssets (#383)

Co-authored-by: Jay Cho <chojoong@gmail.com>

* [Tizen] Refactor Essential's implementations

* [Tizen] Renaming public APIs Native -> Platform

* [Tizen] Update template & sample's tizen-manifest.xml

* Fix DotNet.csproj to build tizen (#372)

* [Tizen] Update ImageHandler and ImageButtonHandler

* [Tizen] Add handling for TextTransform for SearchBar/Editor/Entry

* [Tizen] Interfaced Handler for Label, Page, NavigationView, Picker,
ProgressBar, SwipeView

* [Tizen] Initial MenuBar

* [Tizen] Moved GetPlatformSize logic into a new service

* [Tizen] Interfaced handler for Switch, TimePicker, WebView, Slider,
SearchBar, RefreshView, RadioButton

* [Tizen] Fix build error after rebasing

* [Tizen] Use StringComparison.Ordinal everywhere

* [Tizen] Move TabbedPageHandler to TabbedViewHandler

* [Tizen] Add more APIs to IDispatcher

* [Tizen] Remove Application.Properties implementation

* [Tizen] Backport p14 changes

* [Tizen] Implement InputTransparent

* [Tizen] Loaded/Unloaded events and propagate Window

* [Tizen] Fix Path shapes rendering issues

* [Tizen] Fix CI build error on ImageButtonHandler

* [Tizen] Optimize ConfigureFonts and Logging during startup

* [Tizen] Make sure StrokeDashArray property invalidate the Shape

* [Tizen] Implement FillRule property in Polygon/PolylineHandler

* [Tizen] Add install tizen to provision.yml

* [Tizen] Simplify OnPlatformExtension

* [Tizen] Use interface on mappers of shapes

* [Tizen] Install tizen workload on dotnet-local-workloads

* [Tizen] Move package version into Versions.props

* [Tizen] Move 'UseMauiApp' call into "Controls"

* [Tizen] update template description of localized string files

* [Tizen] Update the package reference of Microsoft.Maui.Dependencies

* [Tizen] Add IWindow.DisplayDensity

* [Tizen] Initial VisualDiagnostic Image APIs

* [Tizen] Mark all the Device [Obsolete]

* [Tizen] Mark renderers and related base classes as obsolete

* [Tizen] Platform behavior implementation

* [Tizen] Clean unnecessary resource files

* [Tizen] Graphics events

* [Tizen] Modernize Essentials Namepsaces

* [Tizen] Fix Compat's control gallery build error

* Fix ClipperView background color issue (#447)

* Fix typo (#450)

* [Tizen] Initial support for configuring the underlying Web view settings

* [Tizen] BlazorWebView public API tracking

* [Tizen] use latest tizen workload as default

* [Tizen] specify sdk version to avoid ci build error

* [Tizen] Keep the text wrapping/truncation and max lines stuff in Controls

* [Tizen] Remove downcasts in BlazorWebView

* [Tizen] BlazorWebView API review changes: Shared sources

* [Tizen] add tizen TFM optional

* [Tizen] adding informative comments for template

* [Tizen] Set IncludeTizenTargetFrameworks correctly

* [Tizen] install maui-tizen

Co-authored-by: JoonghyunCho <jh5.cho@samsung.com>
Co-authored-by: Seungkeun Lee <sngn.lee@samsung.com>
Co-authored-by: 김성수/Common Platform Lab(SR)/Staff Engineer/삼성전자 <sung-su.kim@samsung.com>
Co-authored-by: 박인서/Common Platform Lab(SR)/Associate/삼성전자 <inseo9.park@samsung.com>
Co-authored-by: 민성현/Common Platform Lab(SR)/Staff Engineer/삼성전자 <shyun.min@samsung.com>
Co-authored-by: Jay Cho <chojoong@gmail.com>
@ghost ghost added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Jul 11, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2023
@Eilon Eilon removed area/toolbar legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor area-image Image loading, sources, caching area-layout StackLayout, GridLayout, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter labels May 10, 2024
@samhouts samhouts added the fixed-in-6.0.100-preview.7.3 Look for this fix in 6.0.100-preview.7.3! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattleibow mattleibow mattleibow left review comments

@hartez hartez hartez approved these changes

@jsuarezruiz jsuarezruiz jsuarezruiz approved these changes

@PureWeen PureWeen Awaiting requested review from PureWeen

Assignees
No one assigned
Labels
area-controls-flyout Flyout area-controls-flyoutpage FlyoutPage area-controls-image Image control area-controls-listview ListView and TableView area-controls-scrollview ScrollView area-controls-titleview TitleView area-controls-toolbar ToolBar fixed-in-6.0.100-preview.7.3 Look for this fix in 6.0.100-preview.7.3! layout-absolute layout-grid layout-relative layout-stack platform/android 🤖 platform/iOS 🍎 platform/windows 🪟
Projects
None yet
Milestone
6.0.100-preview.7
Development

Successfully merging this pull request may close these issues.
8 participants
@rmarinho @jsuarezruiz @hartez @mattleibow @Eilon @Redth @PureWeen @samhouts