Missing SdkResolverResolveSdk/Stop event

[rainersigwald]

I've been looking at a few ETW traces, and I can see Microsoft-Build/SdkResolverResolveSdk/Start events, but no corresponding Stop event.

Since the info about the resolver and the SDK to be resolved is in Stop, this is unfortunate:

msbuild/src/Build/BackEnd/Components/SdkResolution/SdkResolverService.cs

Lines 324 to 326 in 47a7121

	MSBuildEventSource.Log.SdkResolverResolveSdkStart();
	result = (SdkResult)sdkResolver.Resolve(sdk, context, resultFactory);
	MSBuildEventSource.Log.SdkResolverResolveSdkStop(sdkResolver.Name, sdk.Name, solutionPath, projectPath, result?.Path, result?.Success ?? false);

Watching in the debugger, I can see that we're calling our event

msbuild/src/Framework/MSBuildEventSource.cs

Lines 498 to 502 in 47a7121

	[Event(65, Keywords = Keywords.All)]
	public void SdkResolverResolveSdkStop(string resolverName, string sdkName, string solutionPath, string projectPath, string sdkPath, bool success)
	{
	WriteEvent(65, resolverName, sdkName, solutionPath, projectPath, sdkPath, success);
	}

and it's getting into the underlying call:

>	mscorlib.dll!System.Diagnostics.Tracing.EventSource.WriteEventVarargs(int eventId, System.Guid* childActivityID, object[] args) Line 1894	C#
 	Microsoft.Build.Framework.dll!Microsoft.Build.Eventing.MSBuildEventSource.SdkResolverResolveSdkStop(string resolverName, string sdkName, string solutionPath, string projectPath, string sdkPath, bool success) Line 502	C#
 	Microsoft.Build.dll!Microsoft.Build.BackEnd.SdkResolution.SdkResolverService.TryResolveSdkUsingSpecifiedResolvers(System.Collections.Generic.IList<Microsoft.Build.Framework.SdkResolver> resolvers, int submissionId, Microsoft.Build.Framework.SdkReference sdk, Microsoft.Build.BackEnd.Logging.LoggingContext loggingContext, Microsoft.Build.Construction.ElementLocation sdkReferenceLocation, string solutionPath, string projectPath, bool interactive, bool isRunningInVisualStudio, out Microsoft.Build.BackEnd.SdkResolution.SdkResult sdkResult, out System.Collections.Generic.IEnumerable<string> errors, out System.Collections.Generic.IEnumerable<string> warnings) Line 326	C#
 	Microsoft.Build.dll!Microsoft.Build.BackEnd.SdkResolution.SdkResolverService.ResolveSdkUsingResolversWithPatternsFirst(int submissionId, Microsoft.Build.Framework.SdkReference sdk, Microsoft.Build.BackEnd.Logging.LoggingContext loggingContext, Microsoft.Build.Construction.ElementLocation sdkReferenceLocation, string solutionPath, string projectPath, bool interactive, bool isRunningInVisualStudio, bool failOnUnresolvedSdk) Line 204	C#
 	Microsoft.Build.dll!Microsoft.Build.BackEnd.SdkResolution.SdkResolverService.ResolveSdk(int submissionId, Microsoft.Build.Framework.SdkReference sdk, Microsoft.Build.BackEnd.Logging.LoggingContext loggingContext, Microsoft.Build.Construction.ElementLocation sdkReferenceLocation, string solutionPath, string projectPath, bool interactive, bool isRunningInVisualStudio, bool failOnUnresolvedSdk) Line 134	C#

I've seen this on 17.6.0-preview-23122-03+f93b24b5a for .NET Framework as well as 17.5.0-preview-23061-01+040e2a90e for .NET, and in some traces from others that should be on older released versions.

[jeffkl]

I think my PR would fix this but I never had time to really dive into it and my suggested fix wasn't well received.

#7497

[Forgind]

I think my PR would fix this but I never had time to really dive into it and my suggested fix wasn't well received.

#7497

Would you mind explaining what versions have to do with events not firing? I'm confused as to what the versions are defaulting to or why they would be different from each other.

[rainersigwald]

The move to finally didn't solve this.

[rainersigwald]

Instead of the real events we get

EventSourceException while processing event "SdkResolverResolveSdkStop": Null passed as a event argument.
EventSourceException while processing event "CachedSdkResolverServiceResolveSdkStop": Null passed as a event argument.