Make ProjectShouldBuild public #7992
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
Therzok
reviewed
Oct 1, 2022
| @@ -252,8 +252,9 @@ internal string SolutionFileDirectory | |||
|
|
|||
| #region Methods | |||
|
|
|||
| internal bool ProjectShouldBuild(string projectFile) | |||
| public bool ProjectShouldBuild(string projectFile) | |||
There was a problem hiding this comment.
@mrward is this something we might be able to use in vsmac as well?
There was a problem hiding this comment.
VS Mac has its own logic here - the project filtered out by the slnf file is not loaded and so would not be restored.
There was a problem hiding this comment.
We ultimately decided this isn't the way to go, so it will remain risky to rely on ProjectShouldBuild staying as it is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
NuGet wants to access whether a particular project was filtered out by a solution filter file. They had previously called SolutionFile.Parse. We have a ProjectShouldBuild method that can be called on a SolutionFile. This makes that method public, hence accessible.