Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package the experimental analyzers along with the FxCopAnalyzers and … #1622

Merged
merged 1 commit into from
Mar 1, 2018

Conversation

mavasani
Copy link
Contributor

@mavasani mavasani commented Mar 1, 2018

…Microsoft.Net.RoslynDiagnostics NuGet packages

Verified it works locally:

image

…Microsoft.Net.RoslynDiagnostics NuGet packages
@mavasani mavasani requested a review from a team March 1, 2018 00:58
@jinujoseph
Copy link
Contributor

whats ci here ? should it say beta ?

@mavasani
Copy link
Contributor Author

mavasani commented Mar 1, 2018

whats ci here ? should it say beta ?

That's just the package name when CIBuild.cmd is executed locally. We will generate the correct package names on signed build machine.

@333fred
Copy link
Member

333fred commented Mar 1, 2018

Could we conditionally include the Exp package only if the release version is suffixed with alpha/beta? I'm concerned about, in the future, us creating some experiment and doing a release at the same time, and shipping the release package with the experimental package.

@jinujoseph
Copy link
Contributor

+1 on Freds proposal

@mavasani
Copy link
Contributor Author

mavasani commented Mar 1, 2018

Our signed build always generates prerelease packages. We have to manually run NuGetRepack on prerelease packages to produce release packages.

@mavasani
Copy link
Contributor Author

mavasani commented Mar 1, 2018

@333fred Are you fine with the current change?

Copy link
Member

@333fred 333fred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We talked offline. We'll work on making repack understand that it shouldn't ship the exp package in non-prerelease scenarios.

@mavasani
Copy link
Contributor Author

mavasani commented Mar 1, 2018

@333fred Filed dotnet/roslyn-tools#174 to track your request.

@mavasani mavasani merged commit 860a638 into dotnet:master Mar 1, 2018
@mavasani mavasani deleted the packaging branch March 1, 2018 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants