-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package the experimental analyzers along with the FxCopAnalyzers and … #1622
Conversation
…Microsoft.Net.RoslynDiagnostics NuGet packages
whats ci here ? should it say beta ? |
That's just the package name when CIBuild.cmd is executed locally. We will generate the correct package names on signed build machine. |
Could we conditionally include the Exp package only if the release version is suffixed with alpha/beta? I'm concerned about, in the future, us creating some experiment and doing a release at the same time, and shipping the release package with the experimental package. |
+1 on Freds proposal |
Our signed build always generates prerelease packages. We have to manually run NuGetRepack on prerelease packages to produce release packages. |
@333fred Are you fine with the current change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We talked offline. We'll work on making repack understand that it shouldn't ship the exp package in non-prerelease scenarios.
@333fred Filed dotnet/roslyn-tools#174 to track your request. |
…Microsoft.Net.RoslynDiagnostics NuGet packages
Verified it works locally: