Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for CodeMetricsAnalyzer performance #7118

Merged
merged 12 commits into from
Jan 2, 2024

Conversation

sharwell
Copy link
Member

@sharwell sharwell commented Dec 28, 2023

Review commit-by-commit recommended

@sharwell sharwell requested a review from a team as a code owner December 28, 2023 21:29
Copy link

codecov bot commented Dec 28, 2023

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (5dc99c6) 96.42% compared to head (4f9757f) 96.42%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7118      +/-   ##
==========================================
- Coverage   96.42%   96.42%   -0.01%     
==========================================
  Files        1412     1411       -1     
  Lines      337058   337237     +179     
  Branches    11145    11153       +8     
==========================================
+ Hits       325020   325189     +169     
- Misses       9231     9242      +11     
+ Partials     2807     2806       -1     

@mavasani
Copy link
Member

mavasani commented Jan 2, 2024

@sharwell Is this PR fixing a customer reported issue?

@sharwell
Copy link
Member Author

sharwell commented Jan 2, 2024

@mavasani It's based on information gathered from https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1932642, but I wouldn't go so far as to call it a fix for the issue.

@sharwell sharwell merged commit 8a92037 into dotnet:main Jan 2, 2024
11 checks passed
@sharwell sharwell deleted the metrics-perf branch January 2, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants