Don't assume Type is non-null

dotnet · Aug 14, 2019 · 499890d · 499890d · CyrusNajmabadi · Aug 14, 2019
1 parent cc00ecd
commit 499890d
Showing 1 changed file with 7 additions and 7 deletions.
diff --git a/src/Features/CSharp/Portable/QuickInfo/CSharpSemanticQuickInfoProvider.cs b/src/Features/CSharp/Portable/QuickInfo/CSharpSemanticQuickInfoProvider.cs
@@ -86,19 +86,19 @@ protected override ImmutableArray<TaggedText> TryGetNullabilityAnalysis(Workspac
                 return default;
             }
 
-            var typeInfo = semanticModel.GetTypeInfo(bindableParent, cancellationToken);
-
-            if (typeInfo.Type.IsValueType)
-            {
-                return default;
-            }
-
             switch (symbolInfo.Symbol)
             {
                 case IFieldSymbol { HasConstantValue: true }: return default;
                 case ILocalSymbol { HasConstantValue: true }: return default;
             }
 
+            var typeInfo = semanticModel.GetTypeInfo(bindableParent, cancellationToken);
+
+            if (typeInfo.Type?.IsValueType == true)
+            {
+                return default;
+            }
+
             string messageTemplate = null;
 
             if (typeInfo.Nullability.FlowState == NullableFlowState.NotNull)