Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Braces Analyzer/Code Fix #10942

Closed
Hosch250 opened this issue Apr 28, 2016 · 8 comments
Closed

Use Braces Analyzer/Code Fix #10942

Hosch250 opened this issue Apr 28, 2016 · 8 comments
Assignees
@CyrusNajmabadi
Labels
Area-IDE help wanted The issue is "up for grabs" - add a comment if you are interested in working on it
Milestone
2.0 (Preview 3)

Comments

@Hosch250
Copy link
Contributor

Version Used: Latest master

Steps to Reproduce:

  1. Create an if with only one statement.
  2. Fail to use braces.

Expected Behavior:
Roslyn says to use braces and offers a quick fix.

Actual Behavior:
Roslyn doesn't make any comment.
@Hosch250
Copy link
Contributor Author

Hosch250 commented Apr 28, 2016 •
edited
Loading

This was discussed in chat. I am prepared to implement this if you wish.

@gafter gafter added help wanted The issue is "up for grabs" - add a comment if you are interested in working on it Area-Analyzers labels Apr 28, 2016
@jasonmalinowski
Copy link
Member

@srivatsn, @Pilchie, @Hosch250 is curious to know in Gitter how he should pick the right ID for the analyzer and codefix. What's our pattern here?

@srivatsn
Copy link
Contributor

srivatsn commented May 3, 2016

We've been using IDE00xx as the ids (here).

@Hosch250
Copy link
Contributor Author

Hosch250 commented May 3, 2016

OK, I'll create a new IDE00xx ID for this when.

@Pilchie Pilchie added this to the 2.0 (Preview 3) milestone May 6, 2016
@Pilchie
Copy link
Member

Pilchie commented May 6, 2016

@CyrusNajmabadi can you work with @Hosch250 on this?

@Hosch250
Copy link
Contributor Author

Hosch250 commented May 6, 2016

I'll let you know when I'm ready. I have a full-time internship now, so I don't have much time for other projects.

@CyrusNajmabadi
Copy link
Member

I'm happy to help with this.

@Hosch250
Copy link
Contributor Author

Hosch250 commented May 6, 2016

I hope to work on it this weekend--it shouldn't be hard since I've already done it all before in another project.

This was referenced May 7, 2016
Closed
Merged
CyrusNajmabadi added a commit that referenced this issue May 10, 2016
@CyrusNajmabadi
Merge pull request #11168 from Hosch250/UseBraces2
a3772f5 
Adds an analyzer/codefix for adding missing braces

Fixes #10942
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CyrusNajmabadi CyrusNajmabadi

Labels
Area-IDE help wanted The issue is "up for grabs" - add a comment if you are interested in working on it
Projects
None yet
Milestone
2.0 (Preview 3)
Development

Successfully merging a pull request may close this issue.

Close #10942
6 participants
@srivatsn @jasonmalinowski @Pilchie @gafter @CyrusNajmabadi @Hosch250