Close #10942 #11163
Close #10942 #11163
Conversation
Update FX dependencies to build 24011
Remove System.AppContext to Roslyn.VisualStudio.InteractiveComponents
invoke next handler in case if no signature help providers can be fou…
…-future20160418-171208
Fix compiler crash in broken code in pattern matching
This reverts commit ca967cf.
… behind a feature flag""" This reverts commit a96d782.
…18-171208 Merge master into future
Update TargetFrameworkVersions.
Target netstandard 1.3
Add missing project.json
Add DSR.Portable project.json to .csproj
| { | ||
| private static readonly LocalizableString s_localizableTitle = | ||
| new LocalizableResourceString(nameof(FeaturesResources.AddBraces), FeaturesResources.ResourceManager, | ||
| typeof (FeaturesResources)); |
|
A few more tweaks to make. almost there! |
| var diagnosticSpan = diagnostic.Location.SourceSpan; | ||
| var statement = root.FindNode(diagnosticSpan); | ||
|
|
||
| SyntaxNode newBlock = null; |
There was a problem hiding this comment.
Nit: my preferred patternfor this is to have a helper method which returns the new block. That way in the switch all the cases can just return instead of needing to assign then break. Your call on if you want that .
|
👍 with the change to make this hidden by default. If you're still having test problems i'm happy to take a look. |
|
I haven't tried it on my machine lately, but the tests are failing on this build as well, indicating the problem is still there. |
|
Ok! I'll look at the tests! |
|
i burnt a finger cooking though. So i may have to wait till later. it's not fun typing right now :) |
|
Also, i just talked with @Pilchie . We'd like this to be agianst Future. I'm happy to rebase things for you if you're not famliar with doing that. |
|
I'm not familiar doing that, so that would be nice. Wait for my next commit, please, after I respond to your comments. |
|
Sure! can you give me permissions to push to your repo? |
|
Sure. Let me look at my settings. |
|
It should be under settings -> collaborators |
|
Found it. You have push access. |
|
Just manually testing it before I commit. |
|
Ok. Let me know when i can make changes. Because i'll be rewriting history, i'll need to do a force push. And i don't want to do that while you're in the middle of things. |
|
Go ahead. |
|
Once you do this, I will need to close this and re-PR against Future? |
|
@CyrusNajmabadi I looked in the log files, and this is the error:
I was working on this before the last release, and when I opened it after pulling all the latest changes, I had to clear and re-restore my nuget packages. Is this part of the problem? |
|
I got the tests working, @CyrusNajmabadi, don't worry about them (another 'restore.cmd' did the trick). A couple of them are failing, so I'll fix those and update the PR later (probably tomorrow). Feel free to rebase things any time, unless you would rather have me create a new branch off Future and move my changes over. |
…h's, while's, do-while's, and using's.
|
Ok. I've rebased and pushed. You will have to close and open a new PR against future. Thanks! |
Diagnostic/quick fix for adding braces to if's, else's, for's, foreach's, while's, do-while's, and using's.
Close #10942