VS 2017 RC3 crashes somewhere in Microsoft.CodeAnalysis.Workspaces.dll #16900
Comments
|
Well, that's an unfortunately useless stack :-( Have you got a crash dump from when this happens that you can upload somewhere? |
|
Where can I find it? I can reproduce it any time. |
|
You'll have to attach and save it from VS, or else if you always want Windows to save dumps when devenv.exe crashes, you can set: |
|
I think setting procdump to write dump when process terminates or as a post mortem debugger should also work |
|
This is what |
|
Dump created via Task Manager https://drive.google.com/open?id=0B8HLQUKik9VtOUU4TzlhZnl6VkU |
|
It always crashes now, after updating to RC3. I cannot do anything in it. |
|
Another one https://drive.google.com/open?id=0B8HLQUKik9VtOUU4TzlhZnl6VkU, it was auto created after I added the registry keys. |
|
@heejaechang The internal exception that we're throwing on is: Which seems to be here, but I don't see how |
|
@vasily-kirichenko Looks like that is actually the same link twice. Also, the taskmgr dump is 64-bit which makes it hard to look at managed code in. In future, if you could start |
|
@Pilchie hmmm.. that is weird. that seems something can't happen. |
Pilchie
added
Bug
Tenet-Reliability
|
I don't have access to the actual source but in the constructor of ServiceHubServiceBase we leak |
|
@vladima Nice catch - that sounds plausible. @heejaechang can you take a look? |
|
This link should work https://drive.google.com/open?id=0B8HLQUKik9VtMDJtQXpDVzdnbUU |
|
A better stack from the new dump: |
|
@vasily-kirichenko is this repeatedly repro-able? if so, can I get repro step to dig in? |
|
it is hard to tell without looking at the source code but can it be that @AArnott can it be the case? |
|
@heejaechang it reproduces on my machine at work only. It's quite messy: it's survived VS 2017 preview 5, RC, RC2 and now RC3. I cannot reproduce it at home, on a clean windows + RC3 installation. |
|
@vasily-kirichenko thank you for helping us on this issue. |
|
@vladima @AArnott I am working with Kiran to confirm that VS only get Stream back once SnapshotService is fully constructed. which makes the above issue not possible to happen. it can't be thread-sync issue as well since I am using lock that should put memory barrier to sync all read/write between threads. |
|
so, I have been trying to repro this by requesting snapshot service concurrently to servicehub 4000 times. and this doesn't repro. without actual repro step. it seems very hard to figure out. looks like only thing I can do now is adding some code in service hub service side for us to have better dump. |
|
here is response I got from Kiran for me, that seems a bug. but regardless of that talk, I will guard us from this issue. |
|
@srivatsn @MattGertz @natidea does this meet RTW? |
|
@heejaechang Would be nice to bring -- if we had some idea as to how many people were hitting it and were likely to hit going forward. |
|
@MattGertz I think we have quite a bit of hits I will make a fix just in case we want to bring it to shiproom monday |
|
@heejaechang @Pilchie If this is ready (signoffs and validation) on Saturday, and someone was on tap to do the Roslyn integration, we could get it in theory into the current deliverable via the Sunday afternoon build. I can't see the hits (for some reason, I lost permission, just got auto-approved again but permissions will take time to propagate), so if you have more details that would be good. Otherwise, this will wait until final release. |
|
I confirm that the bug is gone in RC4. Thanks! |
The text was updated successfully, but these errors were encountered: