ExtractMethodCodeRefactoringProvider threw exception #23352

jasonmalinowski · 2017-11-22T00:40:17Z

No repro here, was in the middle of other refactorings and have no idea what I did:

System.InvalidOperationException : Matrix does not contain Key 'C7'.
   at Roslyn.Utilities.Contract.ThrowIfFalse(Boolean condition,String message)
   at Microsoft.CodeAnalysis.ExtractMethod.ExtractMethodMatrix.GetVariableStyle(Boolean captured,Boolean dataFlowIn,Boolean dataFlowOut,Boolean alwaysAssigned,Boolean variableDeclared,Boolean readInside,Boolean writtenInside,Boolean readOutside,Boolean writtenOutside,Boolean unsafeAddressTaken)
   at Microsoft.CodeAnalysis.ExtractMethod.MethodExtractor.Analyzer.GetVariableStyle(Dictionary`2 symbolMap,ISymbol symbol,SemanticModel model,ITypeSymbol type,Boolean captured,Boolean dataFlowIn,Boolean dataFlowOut,Boolean alwaysAssigned,Boolean variableDeclared,Boolean readInside,Boolean writtenInside,Boolean readOutside,Boolean writtenOutside,Boolean unsafeAddressTaken)
   at Microsoft.CodeAnalysis.ExtractMethod.MethodExtractor.Analyzer.GenerateVariableInfoMap(SemanticModel model,DataFlowAnalysis dataFlowAnalysisData,Dictionary`2 symbolMap)
   at async Microsoft.CodeAnalysis.ExtractMethod.MethodExtractor.Analyzer.AnalyzeAsync(<Unknown Parameters>)
   at async Microsoft.CodeAnalysis.ExtractMethod.MethodExtractor.ExtractMethodAsync(<Unknown Parameters>)
   at async Microsoft.CodeAnalysis.ExtractMethod.AbstractExtractMethodService`3.ExtractMethodAsync[TValidator,TExtractor,TResult](<Unknown Parameters>)
   at async Microsoft.CodeAnalysis.CodeRefactorings.ExtractMethod.ExtractMethodCodeRefactoringProvider.GetCodeActionAsync(<Unknown Parameters>)
   at async Microsoft.CodeAnalysis.CodeRefactorings.ExtractMethod.ExtractMethodCodeRefactoringProvider.ComputeRefactoringsAsync(<Unknown Parameters>)
   at async Microsoft.CodeAnalysis.CodeRefactorings.CodeRefactoringService.GetRefactoringFromProviderAsync(<Unknown Parameters>)
   at Microsoft.VisualStudio.Telemetry.WindowsErrorReporting.WatsonReport.GetClrWatsonExceptionInfo(Exception exceptionObject)

The text was updated successfully, but these errors were encountered:

jinujoseph · 2017-12-01T09:52:00Z

also reported at link

AlShadi · 2018-02-01T17:17:53Z

System.InvalidOperationException : Matrix does not contain Key '1A'.
   at Roslyn.Utilities.Contract.ThrowIfFalse(Boolean condition,String message)
   at Microsoft.CodeAnalysis.ExtractMethod.ExtractMethodMatrix.GetVariableStyle(Boolean captured,Boolean dataFlowIn,Boolean dataFlowOut,Boolean alwaysAssigned,Boolean variableDeclared,Boolean readInside,Boolean writtenInside,Boolean readOutside,Boolean writtenOutside,Boolean unsafeAddressTaken)
   at Microsoft.CodeAnalysis.ExtractMethod.MethodExtractor.Analyzer.GetVariableStyle(Dictionary`2 symbolMap,ISymbol symbol,SemanticModel model,ITypeSymbol type,Boolean captured,Boolean dataFlowIn,Boolean dataFlowOut,Boolean alwaysAssigned,Boolean variableDeclared,Boolean readInside,Boolean writtenInside,Boolean readOutside,Boolean writtenOutside,Boolean unsafeAddressTaken)
   at Microsoft.CodeAnalysis.ExtractMethod.MethodExtractor.Analyzer.GenerateVariableInfoMap(SemanticModel model,DataFlowAnalysis dataFlowAnalysisData,Dictionary`2 symbolMap)
   at async Microsoft.CodeAnalysis.ExtractMethod.MethodExtractor.Analyzer.AnalyzeAsync(<Unknown Parameters>)
   at async Microsoft.CodeAnalysis.ExtractMethod.MethodExtractor.ExtractMethodAsync(<Unknown Parameters>)
   at async Microsoft.CodeAnalysis.ExtractMethod.AbstractExtractMethodService`3.ExtractMethodAsync[TValidator,TExtractor,TResult](<Unknown Parameters>)
   at async Microsoft.CodeAnalysis.CodeRefactorings.ExtractMethod.ExtractMethodCodeRefactoringProvider.GetCodeActionAsync(<Unknown Parameters>)
   at async Microsoft.CodeAnalysis.CodeRefactorings.ExtractMethod.ExtractMethodCodeRefactoringProvider.ComputeRefactoringsAsync(<Unknown Parameters>)
   at async Microsoft.CodeAnalysis.CodeRefactorings.CodeRefactoringService.GetRefactoringFromProviderAsync(<Unknown Parameters>)
   at Microsoft.VisualStudio.Telemetry.WindowsErrorReporting.WatsonReport.GetClrWatsonExceptionInfo(Exception exceptionObject)

svick · 2018-02-24T12:17:37Z

I can reproduce this with the code from one of the Developer Community issues:

IEnumerable<object> Crash0(IEnumerable<object> enumerable)
{
    //
    while (true) ;
    return enumerable.Select(e => "");
}

If you select the three lines in the method body, the exception is thrown.

jinujoseph · 2018-03-04T10:21:19Z

resolved in 15.7.P2 via link

mbratukha · 2018-04-11T14:48:58Z

I'm getting similar exception:

System.InvalidOperationException : Matrix does not contain Key 'C7'.
   at Roslyn.Utilities.Contract.ThrowIfFalse(Boolean condition,String message)
   at Microsoft.CodeAnalysis.ExtractMethod.ExtractMethodMatrix.GetVariableStyle(Boolean captured,Boolean dataFlowIn,Boolean dataFlowOut,Boolean alwaysAssigned,Boolean variableDeclared,Boolean readInside,Boolean writtenInside,Boolean readOutside,Boolean writtenOutside,Boolean unsafeAddressTaken)
   at Microsoft.CodeAnalysis.ExtractMethod.MethodExtractor.Analyzer.GetVariableStyle(Dictionary`2 symbolMap,ISymbol symbol,SemanticModel model,ITypeSymbol type,Boolean captured,Boolean dataFlowIn,Boolean dataFlowOut,Boolean alwaysAssigned,Boolean variableDeclared,Boolean readInside,Boolean writtenInside,Boolean readOutside,Boolean writtenOutside,Boolean unsafeAddressTaken)
   at Microsoft.CodeAnalysis.ExtractMethod.MethodExtractor.Analyzer.GenerateVariableInfoMap(SemanticModel model,DataFlowAnalysis dataFlowAnalysisData,Dictionary`2 symbolMap)
   at async Microsoft.CodeAnalysis.ExtractMethod.MethodExtractor.Analyzer.AnalyzeAsync(<Unknown Parameters>)
   at async Microsoft.CodeAnalysis.ExtractMethod.MethodExtractor.ExtractMethodAsync(<Unknown Parameters>)
   at async Microsoft.CodeAnalysis.ExtractMethod.AbstractExtractMethodService`3.ExtractMethodAsync[TValidator,TExtractor,TResult](<Unknown Parameters>)
   at async Microsoft.CodeAnalysis.CodeRefactorings.ExtractMethod.ExtractMethodCodeRefactoringProvider.GetCodeActionAsync(<Unknown Parameters>)
   at async Microsoft.CodeAnalysis.CodeRefactorings.ExtractMethod.ExtractMethodCodeRefactoringProvider.ComputeRefactoringsAsync(<Unknown Parameters>)
   at async Microsoft.CodeAnalysis.CodeRefactorings.CodeRefactoringService.GetRefactoringFromProviderAsync(<Unknown Parameters>)

Visual Studio: Professional (version 15.6.5)
OS: Windows 10 (version 10.0.16299)

Any ideas?
Do you need maybe any additional information?

heejaechang · 2018-04-11T18:27:49Z

@bratukham thank you let me take a look? do you have a dump by the way I can a look?

mbratukha · 2018-04-12T07:03:41Z

@heejaechang thanks for the answer. I would like to give you a dump, but I do not know how to do that.

heejaechang · 2018-04-12T08:32:21Z

@bratukham how about giving us snippet of code that you were trying to extract out? that will help me to see what happened a bit.

mbratukha · 2018-04-12T14:40:43Z

@heejaechang unfortunately it is not possible to publish my code here. Maybe it is better to create a dump that you asked for?

It happens only in one file and only with several lines of code... The exception is not always thrown, but sometimes always...

heejaechang · 2018-04-12T17:26:17Z

@bratukham if you reproduce the problem, how about sending dump through feedback tool? (https://docs.microsoft.com/en-us/visualstudio/ide/how-to-report-a-problem-with-visual-studio-2017)

you can use this to send dump
https://docs.microsoft.com/en-us/visualstudio/ide/how-to-report-a-problem-with-visual-studio-2017#provide-a-trace-and-heap-dump-optional-a-nameprovideatraceandheapdumpa

Giois93 · 2018-04-17T13:37:20Z

I experimented the same issue on
Visual Studio Enterprise 2017 (15.6.6)
Windows 7 Pro SP1

System.InvalidOperationException : Matrix does not contain Key 'C7'.
   at Roslyn.Utilities.Contract.ThrowIfFalse(Boolean condition,String message)
   at Microsoft.CodeAnalysis.ExtractMethod.ExtractMethodMatrix.GetVariableStyle(Boolean captured,Boolean dataFlowIn,Boolean dataFlowOut,Boolean alwaysAssigned,Boolean variableDeclared,Boolean readInside,Boolean writtenInside,Boolean readOutside,Boolean writtenOutside,Boolean unsafeAddressTaken)
   at Microsoft.CodeAnalysis.ExtractMethod.MethodExtractor.Analyzer.GetVariableStyle(Dictionary`2 symbolMap,ISymbol symbol,SemanticModel model,ITypeSymbol type,Boolean captured,Boolean dataFlowIn,Boolean dataFlowOut,Boolean alwaysAssigned,Boolean variableDeclared,Boolean readInside,Boolean writtenInside,Boolean readOutside,Boolean writtenOutside,Boolean unsafeAddressTaken)
   at Microsoft.CodeAnalysis.ExtractMethod.MethodExtractor.Analyzer.GenerateVariableInfoMap(SemanticModel model,DataFlowAnalysis dataFlowAnalysisData,Dictionary`2 symbolMap)
   at async Microsoft.CodeAnalysis.ExtractMethod.MethodExtractor.Analyzer.AnalyzeAsync(<Unknown Parameters>)
   at async Microsoft.CodeAnalysis.ExtractMethod.MethodExtractor.ExtractMethodAsync(<Unknown Parameters>)
   at async Microsoft.CodeAnalysis.ExtractMethod.AbstractExtractMethodService`3.ExtractMethodAsync[TValidator,TExtractor,TResult](<Unknown Parameters>)
   at async Microsoft.CodeAnalysis.CodeRefactorings.ExtractMethod.ExtractMethodCodeRefactoringProvider.GetCodeActionAsync(<Unknown Parameters>)
   at async Microsoft.CodeAnalysis.CodeRefactorings.ExtractMethod.ExtractMethodCodeRefactoringProvider.ComputeRefactoringsAsync(<Unknown Parameters>)
   at async Microsoft.CodeAnalysis.CodeRefactorings.CodeRefactoringService.GetRefactoringFromProviderAsync(<Unknown Parameters>)

I reproduced the issue selecting several different lines in my code
e.g.
foreach (var wi in checkinNotification.NotificationInfo.WorkItemInfo)

heejaechang · 2018-04-17T18:54:32Z

@Giois93 thank you very much. I will take a look soon.

mbratukha · 2018-04-18T12:57:18Z

@heejaechang unfortunately, I cannot get the same exception anymore...

Fortunately, I have a peace of code, where it was simple to get:

The exception was thrown when one selects from the cursor position (see screenshot above) till the next if statement.

Hope it helps!

MichalGrzegorzak · 2018-04-20T08:41:23Z

Same error, Win 10, VS 2017 Prof (v15.6.6)

System.InvalidOperationException : Matrix does not contain Key 'AB'.
   at Roslyn.Utilities.Contract.ThrowIfFalse(Boolean condition,String message)
   at Microsoft.CodeAnalysis.ExtractMethod.ExtractMethodMatrix.GetVariableStyle(Boolean captured,Boolean dataFlowIn,Boolean dataFlowOut,Boolean alwaysAssigned,Boolean variableDeclared,Boolean readInside,Boolean writtenInside,Boolean readOutside,Boolean writtenOutside,Boolean unsafeAddressTaken)
   at Microsoft.CodeAnalysis.ExtractMethod.MethodExtractor.Analyzer.GetVariableStyle(Dictionary`2 symbolMap,ISymbol symbol,SemanticModel model,ITypeSymbol type,Boolean captured,Boolean dataFlowIn,Boolean dataFlowOut,Boolean alwaysAssigned,Boolean variableDeclared,Boolean readInside,Boolean writtenInside,Boolean readOutside,Boolean writtenOutside,Boolean unsafeAddressTaken)
   at Microsoft.CodeAnalysis.ExtractMethod.MethodExtractor.Analyzer.GenerateVariableInfoMap(SemanticModel model,DataFlowAnalysis dataFlowAnalysisData,Dictionary`2 symbolMap)
   at async Microsoft.CodeAnalysis.ExtractMethod.MethodExtractor.Analyzer.AnalyzeAsync(<Unknown Parameters>)
   at async Microsoft.CodeAnalysis.ExtractMethod.MethodExtractor.ExtractMethodAsync(<Unknown Parameters>)
   at async Microsoft.CodeAnalysis.ExtractMethod.AbstractExtractMethodService`3.ExtractMethodAsync[TValidator,TExtractor,TResult](<Unknown Parameters>)
   at async Microsoft.CodeAnalysis.CodeRefactorings.ExtractMethod.ExtractMethodCodeRefactoringProvider.GetCodeActionAsync(<Unknown Parameters>)
   at async Microsoft.CodeAnalysis.CodeRefactorings.ExtractMethod.ExtractMethodCodeRefactoringProvider.ComputeRefactoringsAsync(<Unknown Parameters>)
   at async Microsoft.CodeAnalysis.CodeRefactorings.CodeRefactoringService.GetRefactoringFromProviderAsync(<Unknown Parameters>)

sharwell · 2018-04-20T10:53:58Z

@MichalGrzegorzak That appears to be a different issue (the key 'AB' is different from previous reports). Can you file a new issue for it?

aukaurea · 2018-05-03T15:27:18Z

System.InvalidOperationException : Matrix does not contain Key 'C7'.
   at Roslyn.Utilities.Contract.ThrowIfFalse(Boolean condition,String message)
   at Microsoft.CodeAnalysis.ExtractMethod.ExtractMethodMatrix.GetVariableStyle(Boolean captured,Boolean dataFlowIn,Boolean dataFlowOut,Boolean alwaysAssigned,Boolean variableDeclared,Boolean readInside,Boolean writtenInside,Boolean readOutside,Boolean writtenOutside,Boolean unsafeAddressTaken)
   at Microsoft.CodeAnalysis.ExtractMethod.MethodExtractor.Analyzer.GetVariableStyle(Dictionary`2 symbolMap,ISymbol symbol,SemanticModel model,ITypeSymbol type,Boolean captured,Boolean dataFlowIn,Boolean dataFlowOut,Boolean alwaysAssigned,Boolean variableDeclared,Boolean readInside,Boolean writtenInside,Boolean readOutside,Boolean writtenOutside,Boolean unsafeAddressTaken)
   at Microsoft.CodeAnalysis.ExtractMethod.MethodExtractor.Analyzer.GenerateVariableInfoMap(SemanticModel model,DataFlowAnalysis dataFlowAnalysisData,Dictionary`2 symbolMap)
   at async Microsoft.CodeAnalysis.ExtractMethod.MethodExtractor.Analyzer.AnalyzeAsync(<Unknown Parameters>)
   at async Microsoft.CodeAnalysis.ExtractMethod.MethodExtractor.ExtractMethodAsync(<Unknown Parameters>)
   at async Microsoft.CodeAnalysis.ExtractMethod.AbstractExtractMethodService`3.ExtractMethodAsync[TValidator,TExtractor,TResult](<Unknown Parameters>)
   at async Microsoft.CodeAnalysis.CodeRefactorings.ExtractMethod.ExtractMethodCodeRefactoringProvider.GetCodeActionAsync(<Unknown Parameters>)
   at async Microsoft.CodeAnalysis.CodeRefactorings.ExtractMethod.ExtractMethodCodeRefactoringProvider.ComputeRefactoringsAsync(<Unknown Parameters>)
   at async Microsoft.CodeAnalysis.CodeRefactorings.CodeRefactoringService.GetRefactoringFromProviderAsync(<Unknown Parameters>)

dedpichto · 2018-05-20T09:19:12Z

VS 2017 Community edition version 15.6.7.
I have WPF project with WndProc procedure for main window. Each time I select any portion of code within WndProc, the error occurs. It doesn't happen in other parts of code.

System.InvalidOperationException : Matrix does not contain Key 'C7'.
at Roslyn.Utilities.Contract.ThrowIfFalse(Boolean condition,String message)
at Microsoft.CodeAnalysis.ExtractMethod.ExtractMethodMatrix.GetVariableStyle(Boolean captured,Boolean dataFlowIn,Boolean dataFlowOut,Boolean alwaysAssigned,Boolean variableDeclared,Boolean readInside,Boolean writtenInside,Boolean readOutside,Boolean writtenOutside,Boolean unsafeAddressTaken)
at Microsoft.CodeAnalysis.ExtractMethod.MethodExtractor.Analyzer.GetVariableStyle(Dictionary2 symbolMap,ISymbol symbol,SemanticModel model,ITypeSymbol type,Boolean captured,Boolean dataFlowIn,Boolean dataFlowOut,Boolean alwaysAssigned,Boolean variableDeclared,Boolean readInside,Boolean writtenInside,Boolean readOutside,Boolean writtenOutside,Boolean unsafeAddressTaken) at Microsoft.CodeAnalysis.ExtractMethod.MethodExtractor.Analyzer.GenerateVariableInfoMap(SemanticModel model,DataFlowAnalysis dataFlowAnalysisData,Dictionary2 symbolMap)
at async Microsoft.CodeAnalysis.ExtractMethod.MethodExtractor.Analyzer.AnalyzeAsync()
at async Microsoft.CodeAnalysis.ExtractMethod.MethodExtractor.ExtractMethodAsync()
at async Microsoft.CodeAnalysis.ExtractMethod.AbstractExtractMethodService`3.ExtractMethodAsyncTValidator,TExtractor,TResult
at async Microsoft.CodeAnalysis.CodeRefactorings.ExtractMethod.ExtractMethodCodeRefactoringProvider.GetCodeActionAsync()
at async Microsoft.CodeAnalysis.CodeRefactorings.ExtractMethod.ExtractMethodCodeRefactoringProvider.ComputeRefactoringsAsync()
at async Microsoft.CodeAnalysis.CodeRefactorings.CodeRefactoringService.GetRefactoringFromProviderAsync()

mbratukha · 2018-07-26T08:14:57Z

I've got similar issue, but with key 'C6': #28846

jasonmalinowski added the Area-IDE label Nov 22, 2017

jinujoseph added this to the Unknown milestone Dec 1, 2017

jinujoseph added Bug Developer Community The issue was originally reported on https://developercommunity.visualstudio.com labels Dec 1, 2017

jinujoseph assigned dpoeschl Dec 20, 2017

jinujoseph modified the milestones: Unknown, 15.6 Dec 20, 2017

This was referenced Jan 8, 2018

'ExtractMethodCodeRefactoringProvider' encountered an error and has been disabled when selecting a line #23880

Closed

ExtractMethod: Weird VS 2017 15.4.4 behaviour #23401

Closed

jinujoseph modified the milestones: 15.6, 15.7 Jan 23, 2018

alrz mentioned this issue Feb 24, 2018

ExtractMethodCodeRefactoringProvider encountered an error and has been disabled #23175

Closed

heejaechang mentioned this issue Mar 1, 2018

Fixed bug where extract method throws on unreachable code or local function parameter #25147

Merged

jinujoseph added the 4 - In Review A fix for the issue is submitted for review. label Mar 2, 2018

jinujoseph assigned heejaechang and unassigned dpoeschl Mar 2, 2018

jinujoseph closed this as completed Mar 4, 2018

jinujoseph added Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented and removed 4 - In Review A fix for the issue is submitted for review. labels Mar 4, 2018

jinujoseph mentioned this issue Aug 28, 2018

Extract-method C7 crash #29536

Closed

jinujoseph mentioned this issue Nov 19, 2018

ExtractMethodCodeRefactoringProvider encountered an error and has been disabled. #31249

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ExtractMethodCodeRefactoringProvider threw exception #23352

ExtractMethodCodeRefactoringProvider threw exception #23352

jasonmalinowski commented Nov 22, 2017

jinujoseph commented Dec 1, 2017 •

edited

Loading

AlShadi commented Feb 1, 2018 •

edited by sharwell

Loading

svick commented Feb 24, 2018

jinujoseph commented Mar 4, 2018

mbratukha commented Apr 11, 2018

heejaechang commented Apr 11, 2018

mbratukha commented Apr 12, 2018

heejaechang commented Apr 12, 2018

mbratukha commented Apr 12, 2018

heejaechang commented Apr 12, 2018

Giois93 commented Apr 17, 2018 •

edited by sharwell

Loading

heejaechang commented Apr 17, 2018

mbratukha commented Apr 18, 2018

MichalGrzegorzak commented Apr 20, 2018 •

edited by sharwell

Loading

sharwell commented Apr 20, 2018

aukaurea commented May 3, 2018 •

edited

Loading

dedpichto commented May 20, 2018

mbratukha commented Jul 26, 2018

ExtractMethodCodeRefactoringProvider threw exception #23352

ExtractMethodCodeRefactoringProvider threw exception #23352

Comments

jasonmalinowski commented Nov 22, 2017

jinujoseph commented Dec 1, 2017 • edited Loading

AlShadi commented Feb 1, 2018 • edited by sharwell Loading

svick commented Feb 24, 2018

jinujoseph commented Mar 4, 2018

mbratukha commented Apr 11, 2018

heejaechang commented Apr 11, 2018

mbratukha commented Apr 12, 2018

heejaechang commented Apr 12, 2018

mbratukha commented Apr 12, 2018

heejaechang commented Apr 12, 2018

Giois93 commented Apr 17, 2018 • edited by sharwell Loading

heejaechang commented Apr 17, 2018

mbratukha commented Apr 18, 2018

MichalGrzegorzak commented Apr 20, 2018 • edited by sharwell Loading

sharwell commented Apr 20, 2018

aukaurea commented May 3, 2018 • edited Loading

dedpichto commented May 20, 2018

mbratukha commented Jul 26, 2018

jinujoseph commented Dec 1, 2017 •

edited

Loading

AlShadi commented Feb 1, 2018 •

edited by sharwell

Loading

Giois93 commented Apr 17, 2018 •

edited by sharwell

Loading

MichalGrzegorzak commented Apr 20, 2018 •

edited by sharwell

Loading

aukaurea commented May 3, 2018 •

edited

Loading