You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While running tests locally for #6642 the following tests failed me, but the submitted PR ran fine on Jenkins. Except the first two, they "blend" in the tests that are not set up for encoding related contexts.
Please consider move encoding tests to explicit place for encoding related test and convert the file into UTF8 encoding for tests that are not target for encodings.
The text was updated successfully, but these errors were encountered:
pawchen
changed the title
Consider moving non-unicode tests files to separate projects and apply encoding info to them
Consider moving non-unicode test files to separate projects and apply encoding info to them
Nov 8, 2015
We actually just submitted a PR last week to address the first two suites: #6633. Essentially tests which can only run correctly on specific locales should be enabled on only those locales.
For the other errors I'm not quite following what is going wrong there. Could you elaborate a bit on the problem? Tried looking at the file myself but couldn't immediately see the error.
For the others, example, file: src\Compilers\VisualBasic\Test\Semantic\Semantics\InterpolatedStringTests.vb
Line 195, 209, and 213
Write($"{{Ø}}")
------------------^
This character U+00D8, should be encoded as 0xC3 0x98 in UTF-8, but currently it's 0xD8. You can use a hex editor and check address 0x1424.
You can also use NotePad++ to open the file, Ctrl + G to line 209, and click menu > Encoding > Encode in UTF-8 and see the following screen.
It's easy to fix these files though, see #6647, as NotePad++ can do a convert, but I think the team need to figure out how to prevent this from happening again, actually this is already an again.
While running tests locally for #6642 the following tests failed me, but the submitted PR ran fine on Jenkins. Except the first two, they "blend" in the tests that are not set up for encoding related contexts.
Please consider move encoding tests to explicit place for encoding related test and convert the file into UTF8 encoding for tests that are not target for encodings.
This issue is similar to #5413
The text was updated successfully, but these errors were encountered: