Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partial method '..' must have an implementation part because it has accessibility modifiers.RoslynCS8795 #69522

Closed
onionhammer opened this issue Aug 15, 2023 · 0 comments · Fixed by #70331
Closed

Partial method '..' must have an implementation part because it has accessibility modifiers.RoslynCS8795 #69522

onionhammer opened this issue Aug 15, 2023 · 0 comments · Fixed by #70331
Assignees
@jasonmalinowski
Labels
Area-IDE
Milestone
October 2023

Comments

@onionhammer
Copy link

onionhammer commented Aug 15, 2023 •
edited
Loading

When using VS Code with C# dev kit (not omnisharp), using Riok.Mapperly (which uses source generators), the dev kit fails to realize that partial methods are implemented by a source generator.

C# Dev kit without omnisharp:"S
image

With Omnisharp (and clicking Find all implementations)
image

Originally posted by @onionhammer in #65850 (comment)
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Aug 15, 2023
@jasonmalinowski jasonmalinowski self-assigned this Oct 10, 2023
@jasonmalinowski jasonmalinowski removed the untriaged Issues and PRs which have not yet been triaged by a lead label Oct 10, 2023
@jasonmalinowski jasonmalinowski added this to the October 2023 milestone Oct 10, 2023
@jasonmalinowski jasonmalinowski linked a pull request Oct 11, 2023 that will close this issue
Pass along analyzer references to projects #70331
Merged
@ToddGrun ToddGrun mentioned this issue Jun 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasonmalinowski jasonmalinowski

Labels
Area-IDE
Projects
None yet
Milestone
October 2023
Development

Successfully merging a pull request may close this issue.

Pass along analyzer references to projects jasonmalinowski/roslyn
3 participants
@jaredpar @jasonmalinowski @onionhammer