invoke next handler in case if no signature help providers can be fou… #10673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd (i.e. if document for the text snapshot cannot be found)
|
// cc @CyrusNajmabadi, @jasonmalinowski |
|
👍. Do you want this targeting master, so it'll ship to customers sooner? |
|
Actually, to simplify code flow, let's just merge this too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nd (i.e. if document for the text snapshot was not yet created). This become the issue on the TypeScript side, we analyze open files and its references in order to build the transitive closure of sources that contribute to the program. The actual Roslyn project and documents are created after the analysis is finished. As a consequence when analysis in in progress user cannot type anywhere in the file.