Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Signature Help to features layer #11091

Merged
merged 1 commit into from
May 6, 2016

Conversation

DustinCampbell
Copy link
Member

This PR moves the internal Signature Help data API and provider model from the EditorFeatures layer to the Features layer. The code changes are pretty much exclusively mechanical.

cc @dotnet/roslyn-ide, @mattwar

@DustinCampbell DustinCampbell self-assigned this May 5, 2016
@DustinCampbell DustinCampbell added this to the 1.3 milestone May 5, 2016
@DustinCampbell
Copy link
Member Author

test vsi please

@CyrusNajmabadi
Copy link
Member

Looping in @vladima and @paulvanbrenk

Looks like this is a very minor change. But it may require some code updates in TS to point to new namespaces.

@CyrusNajmabadi
Copy link
Member

👍

1 similar comment
@mattwar
Copy link
Contributor

mattwar commented May 5, 2016

👍

@DustinCampbell
Copy link
Member Author

prtest/win/vsi/p2 -- CSharpInteractiveDirectives failed but passes for me locally. 😒

@DustinCampbell
Copy link
Member Author

retest prtest/win/vsi/p2 please

@DustinCampbell
Copy link
Member Author

prtest/win/vsi/p3 -- CSharpReplIntellisense failed but passes locally for me. 😒

@DustinCampbell
Copy link
Member Author

retest prtest/win/vsi/p3 please

@DustinCampbell
Copy link
Member Author

retest prtest/win/vsi/p0 please

1 similar comment
@DustinCampbell
Copy link
Member Author

retest prtest/win/vsi/p0 please

@DustinCampbell
Copy link
Member Author

prtest/win/vsi/p0 -- BasicChangeSignatureDialog failed but passes locally for me. 😒

@DustinCampbell
Copy link
Member Author

retest prtest/win/vsi/p0 please

1 similar comment
@DustinCampbell
Copy link
Member Author

retest prtest/win/vsi/p0 please

@DustinCampbell
Copy link
Member Author

OK. Everything passed. @CyrusNajmabadi, should I wait for @vladima and @paulvanbrenk before merging?

@DustinCampbell
Copy link
Member Author

DustinCampbell commented May 6, 2016

OK, I heard back from @paulvanbrenk over email. The plan is to wait until after tonight's build and merge tomorrow.

@DustinCampbell
Copy link
Member Author

Huh? All tests (including VSI) had passed on this PR and now there's suddenly new roslyn_prtest_win_vs* tests that got added with two failing? @jaredpar, do you know what this is? I hadn't seen anything in email about these.

@jaredpar
Copy link
Member

jaredpar commented May 6, 2016

@DustinCampbell I forwarded the email that discussed this change being made. Basically just moving the VSI tests over to generated jobs as we did for ETA. This PR hit the middle area where both the manual and generated jobs were in place. The switch is complete now.

I looked at the vsi0 failure and it appears tho job ran correctly here: used master on internal, sync'd to the PR commit and ran the correct BuildAndTest command.

@DustinCampbell
Copy link
Member Author

retest roslyn_prtest_win_vsi0 please

@DustinCampbell
Copy link
Member Author

OK, I can't figure out how to re-run these new jobs and get this PR to pick them up. Since all of the VSI tests had already passed with this change, I'm going to go ahead and merge optimistically.

@DustinCampbell DustinCampbell merged commit 326cdc0 into dotnet:master May 6, 2016
@DustinCampbell DustinCampbell deleted the move-signature-help branch August 21, 2017 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants