-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge master into future #11145
Merged
Merged
Merge master into future #11145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No behavior changes intended.
- Include memebers of underlying type into a set of members returned by tuple type symbol. Properties and events are not supported at the moment. - Track declaration locations for tuple related symbols. - Ensure Rest extensions are tuples.
- Substitute underlying type with corresponding tuple type at the point of type reference. - Adjusted implementation of symbol display to account for presence of names in the extension tuples. - Implemented proper retargeting for tuple types (multi-targeting support).
Use nameof() instead of string literals in ArgumentExceptions
- Added support for properties and events in tuple type symbol. - Made additional adjustments to implementation of tuple symbol display around presence of element names.
) Most of this PR is invisible. What I did was pull down the current toolset packages from azure and replaced the files in the dotnet-cli folder with new ones downloaded from https://github.com/dotnet/cli
@dotnet-bot test vsi please |
Move Signature Help to features layer
Merge tuples to future
…-future20160506-150017 Conflicts: src/Debugging/Roslyn.Reflection.Metadata.Decoding/SignatureDecoder.cs src/Features/CSharp/Portable/CSharpFeaturesResources.resx
test vsi please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatically generated pull request from master into future.
@dotnet/roslyn-infrastructure:
Once the merge can be made and all the tests pass, you are free to merge the pull request.