Switch to straight metadata reading to build our metadata indices for add-using and add-reference. #11183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyrusNajmabadi
added
the
PR For Personal Review Only
CyrusNajmabadi
force-pushed
the
metadataReading
branch
from
c782334
to
a000159
Compare
CyrusNajmabadi
removed
the
PR For Personal Review Only
CyrusNajmabadi
changed the title
|
Tagging @tmat and @dotnet/roslyn-ide |
| @@ -1,6 +1,8 @@ | |||
| // Copyright (c) Microsoft. All Rights Reserved. Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. | |||
|
|
|||
| using System; | |||
| using System.Collections.Generic; | |||
| using System.Reflection.Metadata; | |||
|
@tmat I've addressed your comments. Let me know what you think about the compiler side of things. |
| return info; | ||
| } | ||
|
|
||
| // We don't include internals from metadata assemblies. It's less likely that |
There was a problem hiding this comment.
This comment seems misplaced now. There is no mention of symbol accessibility here.
| // Add all child members | ||
| foreach (var symbol in symbolsWithSameName) | ||
| { | ||
| lookup(symbol, symbolMap); |
There was a problem hiding this comment.
lookup doesn't sound like the right name here.
|
@CyrusNajmabadi A couple more comments. Other than that compiler changes LGTM. |
CyrusNajmabadi
force-pushed
the
metadataReading
branch
from
7d792d1
to
8a8bcfa
Compare
CyrusNajmabadi
force-pushed
the
metadataReading
branch
from
8a8bcfa
to
056b499
Compare
|
👍 |
|
test vsi please |
| return null; | ||
| } | ||
|
|
||
| // Check if we have teh 'Color Color' case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.