Avoid loading the Elfie dll until the user actualy enables the search feature. #11273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging @jasonmalinowski @dotnet/roslyn-ide |
| @@ -36,7 +36,8 @@ internal partial class SymbolSearchService : | |||
| ISymbolSearchService, | |||
| IDisposable | |||
| { | |||
| private ConcurrentDictionary<string, AddReferenceDatabase> _sourceToDatabase = new ConcurrentDictionary<string, AddReferenceDatabase>(); | |||
| // Value is typed as 'object' so we don't load the elfie dll until actually necessary. | |||
| private ConcurrentDictionary<string, object> _sourceToDatabase = new ConcurrentDictionary<string, object>(); | |||
There was a problem hiding this comment.
I'm not a fan of this bit. Suggestions welcome on how i could keep things more strongly typed, while not causing anything in the type system to cause Elfie to load.
There was a problem hiding this comment.
I'm dumb. Will switch to a better approach.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.