Fix Extract Method in methods containing local functions outside the region #18424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -75,6 +75,20 @@ protected override void EnterRegion() | |||
| base.EnterRegion(); | |||
| } | |||
|
|
|||
| protected override void NoteRead(Symbol variable, ParameterSymbol rangeVariableUnderlyingParameter) | |||
There was a problem hiding this comment.
i think we'll need some tests that validate thsi at the compiler level.
|
A lot of test failures here. Is the new behavior expected/desirable? |
The first category of failures was due to accidental omission of a guard to prevent fields from being reported as data-out variables in the new I've convinced myself that the other failures are not desired behavior (a change in the model for code that fails to compile), so I'm working to restore the original behavior in these cases. |
sharwell
added
the
PR For Personal Review Only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17165
Fixes #18347
Tagging @dotnet/roslyn-ide and @agocke for review.