Remove LocalFunctionRewriting pass #21408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Perform synthesis of closure methods to an early pass before visitation, meaning we no longer need to do a second visitation of the tree to lower local functions. Fixes https://github.com/dotnet/roslyn/projects/26#card-3753331
The baselines have been changed because we now do closure id and synthessis in order of closure visitation, rather than bound node visitation. Closure visitation visits all the closures in a given scope, then recurs into nested scopes, while BoundNode visitation treats closures as scopes themselves, so nested closures are visited before closures declared in the same scope.
agocke
force-pushed
the
remove-localfunctionreferencerewriter
branch
from
945e05c
to
64090ae
Compare
TyOverby
reviewed
Aug 11, 2017
| var start = loweredSymbol.ParameterCount - frameCount; | ||
| for (int i = start; i < loweredSymbol.ParameterCount; i++) | ||
| { | ||
| // will always be a LambdaFrame, it's always a capture frame |
khyperia
approved these changes
Aug 14, 2017
| MethodSymbol localFunc, | ||
| out BoundExpression receiver, | ||
| out MethodSymbol method, | ||
| ref ImmutableArray<BoundExpression> parameters) |
There was a problem hiding this comment.
This wasn't changed in this PR, but should this be arguments? (same with parametersBuilder, comments, etc.)
There was a problem hiding this comment.
Yup, I'll file a follow up bug.
gafter
reviewed
Aug 15, 2017
| var syntax = originalMethod.DeclaringSyntaxReferences[0].GetSyntax(); | ||
| var structClosures = closure.CapturedEnvironments | ||
| .Where(env => env.IsStruct).Select(env => env.SynthesizedEnvironment).AsImmutable(); | ||
|
|
There was a problem hiding this comment.
Though this is beautiful, we tend to avoid Linq in the compilers.
There was a problem hiding this comment.
gafter
reviewed
Aug 15, 2017
| translatedLambdaContainer = containerAsFrame = GetStaticFrame(Diagnostics, syntax); | ||
| closureKind = ClosureKind.Singleton; | ||
| closureOrdinal = LambdaDebugInfo.StaticClosureOrdinal; | ||
| } |
There was a problem hiding this comment.
Can merge the tails of both branches (last statement is identical).
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Aug 22, 2017
…-literal-text * dotnet/features/ioperation: Fix no completion in partially written code before 'await'. parameter refness update in local functions/lambda should be caught a… (dotnet#21573) Don't offer to use pattern matching if a user defined operator was involved. Fix crash in VisualBasic.Binder.MemberLookup.AddLookupSymbolsInfoInTypeParameter when it is called with Cref TypeParameter. (dotnet#21586) Additional refactors. Refactor IConditionalChoiceExpression. use PerformIO utility put dispose under finally. Update to Microsoft.DiaSymReader.PortablePdb, Microsoft.DiaSymReader.Converter.Xml to 1.4.0-beta1-62016-01 (dotnet#21557) removed usage of ImmutableArray in json.net Update PULL_REQUEST_TEMPLATE.md Add test documentation to the PR template Remove LocalFunctionRewriting pass (dotnet#21408) PR feedbacks 3 product changes and 1 test change
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Aug 22, 2017
…nversion * dotnet/features/ioperation: (81 commits) Fix no completion in partially written code before 'await'. parameter refness update in local functions/lambda should be caught a… (dotnet#21573) Don't offer to use pattern matching if a user defined operator was involved. Fix crash in VisualBasic.Binder.MemberLookup.AddLookupSymbolsInfoInTypeParameter when it is called with Cref TypeParameter. (dotnet#21586) Additional refactors. Refactor variable names. Refactor IConditionalChoiceExpression. use PerformIO utility put dispose under finally. Update to Microsoft.DiaSymReader.PortablePdb, Microsoft.DiaSymReader.Converter.Xml to 1.4.0-beta1-62016-01 (dotnet#21557) removed usage of ImmutableArray in json.net Update PULL_REQUEST_TEMPLATE.md Add test documentation to the PR template Remove LocalFunctionRewriting pass (dotnet#21408) PR feedbacks Rename parameters. renamed methods. Rename method. Move integration test machines to 15.3 RTM (dotnet#21535) Update comment ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on #21367
Perform synthesis of closure methods to an early pass before visitation,
meaning we no longer need to do a second visitation of the tree to lower
local functions.
Fixes https://github.com/dotnet/roslyn/projects/26#card-3753331