Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parameter refness update in local functions/lambda should be caught a… #21573

Merged
merged 3 commits into from
Aug 17, 2017
Merged

parameter refness update in local functions/lambda should be caught a… #21573

merged 3 commits into from
Aug 17, 2017

Conversation

ivanbasov
Copy link
Contributor

Towards #5156

@ivanbasov ivanbasov requested a review from tmat August 17, 2017 00:59
tmat
tmat reviewed Aug 17, 2017
View reviewed changes
src/Features/CSharp/Portable/EditAndContinue/TopSyntaxComparer.cs Outdated
{
switch (node)
{
case BaseMethodDeclarationSyntax baseMethodDeclarationSyntax: return baseMethodDeclarationSyntax.Body ?? (SyntaxNode)baseMethodDeclarationSyntax.ExpressionBody.Expression;
Copy link
Member

@tmat tmat Aug 17, 2017 •
edited by ivanbasov
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ExpressionBody [](start = 161, length = 14)

This can also be null (e.g. abstract method) #Resolved

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Tons of tests failed due to nulls here. Fixed.

In reply to: 133794525 [](ancestors = 133794525)

tmat
tmat reviewed Aug 17, 2017
View reviewed changes
src/Features/CSharp/Portable/EditAndContinue/TopSyntaxComparer.cs Outdated
return false;
}

ignoreChildFunction = childKind => childKind == SyntaxKind.Block || childKind == SyntaxKind.ArrowExpressionClause || HasLabel(childKind, ignoreVariableDeclarations: true);
Copy link
Member

@tmat tmat Aug 17, 2017 •
edited by ivanbasov
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ignoreVariableDeclarations: true [](start = 157, length = 32)

Can we now remove this parameter (i.e. never ignore variable declarations)? #Resolved

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Thanks! Let us try

In reply to: 133794959 [](ancestors = 133794959)

tmat
tmat approved these changes Aug 17, 2017
View reviewed changes
Copy link
Member

@tmat tmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ivanbasov
Copy link
Contributor Author

test ubuntu_14_debug_prtest please

@ivanbasov ivanbasov merged commit 59f295a into dotnet:master Aug 17, 2017
@ivanbasov ivanbasov deleted the refness branch August 17, 2017 20:43
333fred added a commit to 333fred/roslyn that referenced this pull request Aug 22, 2017
@333fred
Merge remote-tracking branch 'dotnet/features/ioperation' into remove…
d01fef0 
…-literal-text

* dotnet/features/ioperation:
  Fix no completion in partially written code before 'await'.
  parameter refness update in local functions/lambda should be caught a… (dotnet#21573)
  Don't offer to use pattern matching if a user defined operator was involved.
  Fix crash in VisualBasic.Binder.MemberLookup.AddLookupSymbolsInfoInTypeParameter when it is called with Cref TypeParameter. (dotnet#21586)
  Additional refactors.
  Refactor IConditionalChoiceExpression.
  use PerformIO utility
  put dispose under finally.
  Update to Microsoft.DiaSymReader.PortablePdb, Microsoft.DiaSymReader.Converter.Xml to 1.4.0-beta1-62016-01 (dotnet#21557)
  removed usage of ImmutableArray in json.net
  Update PULL_REQUEST_TEMPLATE.md
  Add test documentation to the PR template
  Remove LocalFunctionRewriting pass (dotnet#21408)
  PR feedbacks
  3 product changes and 1 test change
333fred added a commit to 333fred/roslyn that referenced this pull request Aug 22, 2017
@333fred
Merge remote-tracking branch 'dotnet/features/ioperation' into fix-co…
f84920d 
…nversion

* dotnet/features/ioperation: (81 commits)
  Fix no completion in partially written code before 'await'.
  parameter refness update in local functions/lambda should be caught a… (dotnet#21573)
  Don't offer to use pattern matching if a user defined operator was involved.
  Fix crash in VisualBasic.Binder.MemberLookup.AddLookupSymbolsInfoInTypeParameter when it is called with Cref TypeParameter. (dotnet#21586)
  Additional refactors.
  Refactor variable names.
  Refactor IConditionalChoiceExpression.
  use PerformIO utility
  put dispose under finally.
  Update to Microsoft.DiaSymReader.PortablePdb, Microsoft.DiaSymReader.Converter.Xml to 1.4.0-beta1-62016-01 (dotnet#21557)
  removed usage of ImmutableArray in json.net
  Update PULL_REQUEST_TEMPLATE.md
  Add test documentation to the PR template
  Remove LocalFunctionRewriting pass (dotnet#21408)
  PR feedbacks
  Rename parameters.
  renamed methods.
  Rename method.
  Move integration test machines to 15.3 RTM (dotnet#21535)
  Update comment
  ...
333fred added a commit to 333fred/roslyn that referenced this pull request Aug 22, 2017
@333fred
Merge remote-tracking branch 'dotnet/features/ioperation' into refact…
a79c592 
…or-ilocalfunctionstatement

* dotnet/features/ioperation: (38 commits)
  Remove obsolete MEF v1 method of exporting options: [ExportedOption]
  Respond to PR comments (dotnet#21595)
  Add regression test for crash in closure conversion (dotnet#21594)
  Address PR feedback and use a different overload for GetCandidateMembers
  Extract method.
  Do not offer 'use throw expression' if value is accessed before being checked for null.
  Don't offer 'generate overrides' in a static class.
  Fix no completion in partially written code before 'await'.
  parameter refness update in local functions/lambda should be caught a… (dotnet#21573)
  Don't offer to use pattern matching if a user defined operator was involved.
  Give link to new Manual Testing document
  Fix crash in VisualBasic.Binder.MemberLookup.AddLookupSymbolsInfoInTypeParameter when it is called with Cref TypeParameter. (dotnet#21586)
  Fix lock test.
  Additional refactors.
  Refactor variable names.
  Refactor IConditionalChoiceExpression.
  use PerformIO utility
  put dispose under finally.
  Update to Microsoft.DiaSymReader.PortablePdb, Microsoft.DiaSymReader.Converter.Xml to 1.4.0-beta1-62016-01 (dotnet#21557)
  removed usage of ImmutableArray in json.net
  ...
333fred added a commit to 333fred/roslyn that referenced this pull request Aug 22, 2017
@333fred
Merge remote-tracking branch 'dotnet/features/ioperation' into ilabel…
1ddbaac 
…statement-refactor

* dotnet/features/ioperation: (38 commits)
  Remove obsolete MEF v1 method of exporting options: [ExportedOption]
  Respond to PR comments (dotnet#21595)
  Add regression test for crash in closure conversion (dotnet#21594)
  Address PR feedback and use a different overload for GetCandidateMembers
  Extract method.
  Do not offer 'use throw expression' if value is accessed before being checked for null.
  Don't offer 'generate overrides' in a static class.
  Fix no completion in partially written code before 'await'.
  parameter refness update in local functions/lambda should be caught a… (dotnet#21573)
  Don't offer to use pattern matching if a user defined operator was involved.
  Give link to new Manual Testing document
  Fix crash in VisualBasic.Binder.MemberLookup.AddLookupSymbolsInfoInTypeParameter when it is called with Cref TypeParameter. (dotnet#21586)
  Fix lock test.
  Additional refactors.
  Refactor variable names.
  Refactor IConditionalChoiceExpression.
  use PerformIO utility
  put dispose under finally.
  Update to Microsoft.DiaSymReader.PortablePdb, Microsoft.DiaSymReader.Converter.Xml to 1.4.0-beta1-62016-01 (dotnet#21557)
  removed usage of ImmutableArray in json.net
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmat tmat tmat approved these changes

Assignees
No one assigned
Labels
cla-already-signed Interactive-Debugging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ivanbasov @tmat @dnfclas