Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respond to PR comments #21595

Merged
merged 1 commit into from
Aug 18, 2017
Merged

Respond to PR comments #21595

merged 1 commit into from
Aug 18, 2017

Conversation

agocke
Copy link
Member

@agocke agocke commented Aug 17, 2017

Responding to comments from #21408

@gafter
Copy link
Member

gafter commented Aug 17, 2017

I refuse to review a PR entitled "Respond to PR comments".

@agocke
Copy link
Member Author

agocke commented Aug 18, 2017

I think it's always reasonable to be worried about cycles.

@agocke agocke merged commit 68ff197 into dotnet:master Aug 18, 2017
@agocke agocke deleted the pr-comments branch August 18, 2017 22:18
333fred added a commit to 333fred/roslyn that referenced this pull request Aug 22, 2017
…or-ilocalfunctionstatement

* dotnet/features/ioperation: (38 commits)
  Remove obsolete MEF v1 method of exporting options: [ExportedOption]
  Respond to PR comments (dotnet#21595)
  Add regression test for crash in closure conversion (dotnet#21594)
  Address PR feedback and use a different overload for GetCandidateMembers
  Extract method.
  Do not offer 'use throw expression' if value is accessed before being checked for null.
  Don't offer 'generate overrides' in a static class.
  Fix no completion in partially written code before 'await'.
  parameter refness update in local functions/lambda should be caught a… (dotnet#21573)
  Don't offer to use pattern matching if a user defined operator was involved.
  Give link to new Manual Testing document
  Fix crash in VisualBasic.Binder.MemberLookup.AddLookupSymbolsInfoInTypeParameter when it is called with Cref TypeParameter. (dotnet#21586)
  Fix lock test.
  Additional refactors.
  Refactor variable names.
  Refactor IConditionalChoiceExpression.
  use PerformIO utility
  put dispose under finally.
  Update to Microsoft.DiaSymReader.PortablePdb, Microsoft.DiaSymReader.Converter.Xml to 1.4.0-beta1-62016-01 (dotnet#21557)
  removed usage of ImmutableArray in json.net
  ...
333fred added a commit to 333fred/roslyn that referenced this pull request Aug 22, 2017
…statement-refactor

* dotnet/features/ioperation: (38 commits)
  Remove obsolete MEF v1 method of exporting options: [ExportedOption]
  Respond to PR comments (dotnet#21595)
  Add regression test for crash in closure conversion (dotnet#21594)
  Address PR feedback and use a different overload for GetCandidateMembers
  Extract method.
  Do not offer 'use throw expression' if value is accessed before being checked for null.
  Don't offer 'generate overrides' in a static class.
  Fix no completion in partially written code before 'await'.
  parameter refness update in local functions/lambda should be caught a… (dotnet#21573)
  Don't offer to use pattern matching if a user defined operator was involved.
  Give link to new Manual Testing document
  Fix crash in VisualBasic.Binder.MemberLookup.AddLookupSymbolsInfoInTypeParameter when it is called with Cref TypeParameter. (dotnet#21586)
  Fix lock test.
  Additional refactors.
  Refactor variable names.
  Refactor IConditionalChoiceExpression.
  use PerformIO utility
  put dispose under finally.
  Update to Microsoft.DiaSymReader.PortablePdb, Microsoft.DiaSymReader.Converter.Xml to 1.4.0-beta1-62016-01 (dotnet#21557)
  removed usage of ImmutableArray in json.net
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants