Add regression test for crash in closure conversion #21594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredpar
approved these changes
Aug 17, 2017
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Aug 22, 2017
…or-ilocalfunctionstatement * dotnet/features/ioperation: (38 commits) Remove obsolete MEF v1 method of exporting options: [ExportedOption] Respond to PR comments (dotnet#21595) Add regression test for crash in closure conversion (dotnet#21594) Address PR feedback and use a different overload for GetCandidateMembers Extract method. Do not offer 'use throw expression' if value is accessed before being checked for null. Don't offer 'generate overrides' in a static class. Fix no completion in partially written code before 'await'. parameter refness update in local functions/lambda should be caught a… (dotnet#21573) Don't offer to use pattern matching if a user defined operator was involved. Give link to new Manual Testing document Fix crash in VisualBasic.Binder.MemberLookup.AddLookupSymbolsInfoInTypeParameter when it is called with Cref TypeParameter. (dotnet#21586) Fix lock test. Additional refactors. Refactor variable names. Refactor IConditionalChoiceExpression. use PerformIO utility put dispose under finally. Update to Microsoft.DiaSymReader.PortablePdb, Microsoft.DiaSymReader.Converter.Xml to 1.4.0-beta1-62016-01 (dotnet#21557) removed usage of ImmutableArray in json.net ...
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Aug 22, 2017
…statement-refactor * dotnet/features/ioperation: (38 commits) Remove obsolete MEF v1 method of exporting options: [ExportedOption] Respond to PR comments (dotnet#21595) Add regression test for crash in closure conversion (dotnet#21594) Address PR feedback and use a different overload for GetCandidateMembers Extract method. Do not offer 'use throw expression' if value is accessed before being checked for null. Don't offer 'generate overrides' in a static class. Fix no completion in partially written code before 'await'. parameter refness update in local functions/lambda should be caught a… (dotnet#21573) Don't offer to use pattern matching if a user defined operator was involved. Give link to new Manual Testing document Fix crash in VisualBasic.Binder.MemberLookup.AddLookupSymbolsInfoInTypeParameter when it is called with Cref TypeParameter. (dotnet#21586) Fix lock test. Additional refactors. Refactor variable names. Refactor IConditionalChoiceExpression. use PerformIO utility put dispose under finally. Update to Microsoft.DiaSymReader.PortablePdb, Microsoft.DiaSymReader.Converter.Xml to 1.4.0-beta1-62016-01 (dotnet#21557) removed usage of ImmutableArray in json.net ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test fails in both 15.2 and 15.3, but succeeds in master.