Merge dev16.0.x to master #30046

dotnet-bot · 2018-09-20T16:25:50Z

This is an automatically generated pull request from dev16.0.x into master.

git fetch --all
git checkout merges/dev16.0.x-to-master
git reset --hard upstream/master
git merge upstream/dev16.0.x
# Fix merge conflicts
git commit
git push merges/dev16.0.x-to-master --force

Once all conflicts are resolved and all the tests pass, you are free to merge the pull request.

…28825)

Merge master to features/compiler

dotnet/announcements#77 for the change and where I am stealing this change from.

Enable VSTS Testing

…/null-operator-enhancements * dotnet/features/compiler: (145 commits) Don't expose BaseJsonConverter. Expose way to add custom JsonConverters to support external Roslyn OOP services. Delete Contract.* methods that are equivalent to Debug.Assert Update Build.proj SignatureHelp for invocation should select proper overload (#25835) README update Revert. Fix build. Add tests to exercise codepaths. Use set. Make PinnedSolutionInfo type sealed Code Cleanup AB Test (#28625) Fix crash for assignable ref this on RHS of assignment (#28667) remove random last token from format engine. (#26708) Make sure TLS 1.2 is used to fetch from https://dot.net Typos Escape / and : in format string to avoid tests breaking in different locales Remove PR template Disable icacls use on Helix Fix Rename when there is non-SupportsCompilation projects ...

Merge features/compiler

Migrate Linux tests to VSTS

Publish Linux Test Results

Merge master to features/compiler

… into unconstrained-type-parameter-nullability * dotnet/features/NullableReferenceTypes: Include nullability in CheckConstraints (#28959) Use struct for TypeSymbolWithAnnotations (#28943) Publish Linux Test Results Force retest Migrate Linux tests to VSTS Port determinism fixes Make sure TLS 1.2 is used to fetch from https://dot.net Move to language version 8 Make mutex creation more robust Disable icacls use on Helix Disable leak detection tests on x64 VSTS YAML file

…ebug integration test queues

dpoeschl · 2018-10-05T20:45:38Z

@sharwell @jasonmalinowski Okay, resolved functional conflict and the test in question passes locally. Server test results soon.

Skip an integration test and an assert that is firing frequently on d…

…-master

…-to-master

dpoeschl · 2018-10-06T00:12:59Z

@jasonmalinowski Alright. Test from earlier passes, the build break is fixed, the tests surrounding the cause of the build break pass... Surely nothing else will go wrong. 👍

…-master

jasonmalinowski · 2018-10-08T06:10:49Z

@jaredpar Looks like the failure is:

2018-10-08T05:35:37.3143647Z �[39;49m�[31m    Microsoft.CodeAnalysis.CSharp.UnitTests.CodeGen.CodeGenNullCoalescingAssignmentTests.IndexerLvalue [FAIL]
2018-10-08T05:35:37.3156051Z �[39;49m�[37m      Roslyn.Test.Utilities.ExecutionException : 
2018-10-08T05:35:37.3158097Z �[39;49m�[37m      Execution failed for assembly ''.
2018-10-08T05:35:37.3159137Z �[39;49m�[37m      Exception: System.InvalidProgramException: Invalid IL code in C:Main (): IL_0011: stloc.0

Any idea what's up with this?

dpoeschl · 2018-10-08T15:24:09Z

@333fred - It looks like you added these tests a while back. Can you take a look? https://dnceng.visualstudio.com/public/_build/results?buildId=28178&view=logs

Tracking this failure with #30373

(Restarting the tests to see if flaky.)

dpoeschl · 2018-10-08T16:48:11Z

Failed again @ https://dnceng.visualstudio.com/public/_build/results?buildId=28201&view=logs

333fred · 2018-10-08T17:32:48Z

@dpoeschl looking.

jaredpar · 2018-10-08T18:18:22Z

Looks like this is broke on Mono nightly. Let me disable that test.

jaredpar · 2018-10-08T18:19:14Z

Gonna take me 15 minutes to get the Mono bug filed. If you want just disable it now and I'll follow up with a PR to get the appropriate bug attached it shortly.

jasonmalinowski · 2018-10-08T19:06:30Z

@jaredpar We'll just wait. This is an interbranch merge and so honestly it's easier to wait until your skip is in and merge that than run into conflicts.

jaredpar · 2018-10-08T19:23:53Z

Here is the bug report mono/mono#11036

jaredpar · 2018-10-08T19:28:51Z

Test is properly skipped now.

dpoeschl · 2018-10-08T21:40:53Z

The roslyn-CI run finished, but it's not reporting as such here in GitHub. @jaredpar ?

Also, a new test is failing in Linux_Test mono (tracking via #30386):

2018-10-08T19:50:54.2576265Z �[39;49m�[31m    Microsoft.CodeAnalysis.CSharp.UnitTests.CodeGen.DestructorTests.DestructorOverridesNonDestructor [FAIL]
2018-10-08T19:50:54.2588147Z �[39;49m�[37m      Roslyn.Test.Utilities.ExecutionException : 
2018-10-08T19:50:54.2589581Z �[39;49m�[37m      Execution failed for assembly '/tmp/RoslynTests'.
2018-10-08T19:50:54.2589951Z �[39;49m�[37m      Expected: 
2018-10-08T19:50:54.2590219Z �[39;49m�[37m      ~Derived
2018-10-08T19:50:54.2590479Z �[39;49m�[37m      ~Base
2018-10-08T19:50:54.2590710Z �[39;49m�[37m      
2018-10-08T19:50:54.2590942Z �[39;49m�[37m      Actual:   
2018-10-08T19:50:54.2591150Z �[39;49m�[37m      
2018-10-08T19:50:54.2595994Z �[39;49m�[30m      Stack Trace:
2018-10-08T19:50:54.3672328Z �[39;49m�[37m          at (wrapper managed-to-native) System.Reflection.MonoMethod.InternalInvoke(System.Reflection.MonoMethod,object,object[],System.Exception&)
2018-10-08T19:50:54.3676729Z �[39;49m�[37m          at System.Reflection.MonoMethod.Invoke (System.Object obj, System.Reflection.BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x0003b] in <5a872f306a874e34bfe4796f739b7324>:0 
2018-10-08T19:50:54.3679515Z �[39;49m~Derived
2018-10-08T19:50:54.3681333Z ~Base

dpoeschl · 2018-10-08T23:53:09Z

I restarted roslyn-CI from the web portal, and it started https://dnceng.visualstudio.com/public/_build/results?buildId=28479&view=logs... but the "Details" link for roslyn-CI still points to the previous one.

ghost

Auto-approval

dpoeschl · 2018-10-09T16:15:17Z

dotnet-automerge-bot approved these changes 14 hours ago

I guess the correct roslyn-CI got hooked up eventually.

jcouv and others added 30 commits July 30, 2018 14:49

NonNullTypes: tolerate poisoned attribute, but report it before C# 8 (#…

934f39a

…28825)

Merge pull request #28893 from dotnet/merges/master-to-features/compiler

1f385eb

Merge master to features/compiler

Fix msbuild langver test

002ff50

Correctly handle unconstrained type parameters in the NullableWalker

f3a36b9

Merge pull request #28965 from dotnet/merges/master-to-features/compiler

95cb4cb

Merge master to features/compiler

Make sure TLS 1.2 is used to fetch from https://dot.net

3df0f5d

dotnet/announcements#77 for the change and where I am stealing this change from.

Port determinism fixes

e0d21eb

Merge pull request #28853 from jaredpar/fix-nt

5a0e286

Enable VSTS Testing

Address PR feedback

5626b84

Merge pull request #28980 from 333fred/merge-features/compiler

fbfade8

Merge features/compiler

Migrate Linux tests to VSTS

89147f4

Force retest

7489a9a

Merge pull request #28997 from jaredpar/fix-linux

210a865

Migrate Linux tests to VSTS

Publish Linux Test Results

a6c215f

Address PR feedback

8ff9bbd

Merge pull request #28998 from jaredpar/fix-pub

7f19150

Publish Linux Test Results

Added some tests and adjusted parameter name.

524c5ec

Add back missing warn comments.

5117748

Merge pull request #28995 from dotnet/merges/master-to-features/compiler

1c96d92

Merge master to features/compiler

Use struct for TypeSymbolWithAnnotations (#28943)

14efbde

Add IOperation support for Coalescing Assignment.

8959ce6

Include nullability in CheckConstraints (#28959)

0ece26c

Added CFG support for coalescing assignment.

da69bcf

Add semantic model tests.

b73d3f9

Avoid IsValueType in ApplyNullableTransforms (#29045)

a7311a8

Don't warn when returning suppressed null (#29089)

dfb0c1f

Implement "alternative interpolated verbatim" strings (#28355)

a1352c6

Addressed pr feedback.

46c71ef

mavasani and others added 2 commits October 5, 2018 12:16

Skip an integration test and an assert that is firing frequently on d…

999f810

…ebug integration test queues

Update Object Initializer test baseline

90fd0cd

mavasani and others added 5 commits October 5, 2018 14:16

Disable another failing editorconfig test

ba5a2b6

Merge pull request #30342 from mavasani/DisableTestAssert

c6b7941

Skip an integration test and an assert that is firing frequently on d…

Merge remote-tracking branch 'dotnet/master' into merges/dev16.0.x-to…

762418b

…-master

Merge remote-tracking branch 'dotnet/dev16.0.x' into merges/dev16.0.x…

f6cc977

…-to-master

Fix mismerge

4dc51de

Merge remote-tracking branch 'dotnet/master' into merges/dev16.0.x-to…

db49100

…-master

Skip null coalescing test on mono due to nightly bug.

cc70f92

Disable failing test

d7ded2d

dpoeschl closed this Oct 8, 2018

dpoeschl reopened this Oct 8, 2018

dpoeschl mentioned this pull request Oct 8, 2018

Test failure: CodeGen.DestructorTests.DestructorOverridesNonDestructor on Linux_Test mono queue #30386

Open

ghost approved these changes Oct 9, 2018

View reviewed changes

ghost merged commit 14e0068 into master Oct 9, 2018

ghost deleted the merges/dev16.0.x-to-master branch October 9, 2018 02:00

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merge dev16.0.x to master #30046

Merge dev16.0.x to master #30046

dotnet-bot commented Sep 20, 2018

dpoeschl commented Oct 5, 2018

dpoeschl commented Oct 6, 2018

jasonmalinowski commented Oct 8, 2018

dpoeschl commented Oct 8, 2018 •

edited

Loading

dpoeschl commented Oct 8, 2018

333fred commented Oct 8, 2018

jaredpar commented Oct 8, 2018

jaredpar commented Oct 8, 2018

jasonmalinowski commented Oct 8, 2018

jaredpar commented Oct 8, 2018

jaredpar commented Oct 8, 2018

dpoeschl commented Oct 8, 2018 •

edited

Loading

dpoeschl commented Oct 8, 2018

ghost left a comment

dpoeschl commented Oct 9, 2018 •

edited

Loading

Merge dev16.0.x to master #30046

Merge dev16.0.x to master #30046

Conversation

dotnet-bot commented Sep 20, 2018

dpoeschl commented Oct 5, 2018

dpoeschl commented Oct 6, 2018

jasonmalinowski commented Oct 8, 2018

dpoeschl commented Oct 8, 2018 • edited Loading

dpoeschl commented Oct 8, 2018

333fred commented Oct 8, 2018

jaredpar commented Oct 8, 2018

jaredpar commented Oct 8, 2018

jasonmalinowski commented Oct 8, 2018

jaredpar commented Oct 8, 2018

jaredpar commented Oct 8, 2018

dpoeschl commented Oct 8, 2018 • edited Loading

dpoeschl commented Oct 8, 2018

ghost left a comment

Choose a reason for hiding this comment

dpoeschl commented Oct 9, 2018 • edited Loading

dpoeschl commented Oct 8, 2018 •

edited

Loading

dpoeschl commented Oct 8, 2018 •

edited

Loading

dpoeschl commented Oct 9, 2018 •

edited

Loading