Fix issues with using dogfood compilers #31779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmat
changed the title
tmat
changed the title
tmat
added
PR For Personal Review Only
Pilchie
approved these changes
Dec 14, 2018
| <Project> | ||
|
|
||
| <PropertyGroup> | ||
| <MSBuildAllProjects>$(MSBuildAllProjects);$(MSBuildThisFileFullPath)</MSBuildAllProjects> |
There was a problem hiding this comment.
If/when dev16 is a requirement, you can stop adding this. MSBuild now handles it for you, and adding it just leads to annoying LOH allocations.
| Property _TargetAssemblyProjectName is set by GenerateTemporaryTargetAssembly task. | ||
| --> | ||
| <PropertyGroup Condition="'$(IsWpfTempProject)' == 'true'"> | ||
| <_WpfTempProjectNuGetFileNameNoExt>$(ArtifactsObjDir)$(_TargetAssemblyProjectName)\$(_TargetAssemblyProjectName)$(MSBuildProjectExtension).nuget.g</_WpfTempProjectNuGetFileNameNoExt> |
There was a problem hiding this comment.
@jmarolf You can copy the following 2 commits to Arcade SDK:
dotnet/arcade@3d88163
dotnet/arcade@ad721e6
The changes in this PR are Roslyn specific and not needed for Project System.
tmat
changed the title
Run-MSBuild sets various properties based on global variables that were not set in Restore-Project.
tmat
removed
the
PR For Personal Review Only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Infrastructure only change.