Fix parsing regression on switch case expression that is parenthesized unary expression #32166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d unary expression. Fixes dotnet#32161
gafter
added
Area-Compilers
Urgency-Now
New Language Feature - Pattern Matching
333fred
reviewed
Jan 4, 2019
src/Compilers/CSharp/Portable/Parser/LanguageParser_Patterns.cs
Outdated
Show resolved
Hide resolved
cston
reviewed
Jan 4, 2019
| case (+2): break; | ||
| case (~3): break; | ||
| } | ||
| "; |
There was a problem hiding this comment.
Are there other interesting cases? Perhaps:
case (^1): break;
case ((-1)): break;
There was a problem hiding this comment.
I don't think those cases are different in any way that is relevant to the bug or its fix.
| !(SyntaxFacts.IsBinaryExpression(tk) || SyntaxFacts.IsAssignmentExpressionOperatorToken(tk)); | ||
| return isExpression || this.CurrentToken.Kind == SyntaxKind.OpenBraceToken; | ||
| return this.IsPossibleExpression(allowBinaryExpressions: false, allowAssignmentExpressions: false) || | ||
| this.CurrentToken.Kind == SyntaxKind.OpenBraceToken; |
There was a problem hiding this comment.
Thanks! Note: i would personally find it valuable if there was an explanation here (even if brief) as to why neither of these expression forms are allowed. i.e. what hte intuition here is for why this is correct.
There was a problem hiding this comment.
These parameters are about whether binary operator tokens should be accepted. We don't want a token such as == to be considered to be permitted in this context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32161