Merge 'dotnet/master' into DefaultInterfaceImplementation #34044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add method to IsTypeAttributeContextBefore
Fix to Roslyn Style Remove GetNextToken/GetPreviousToken
Remove white line
Fix wrong logic when is not Attribute List
…ons/RegexCharClass.cs Co-Authored-By: CyrusNajmabadi <cyrus.najmabadi@gmail.com>
…oslyn into regexCompletion
…otnet#33892) * Implement LDM decisions on the behavior of `??` and `??=` operators Fixes dotnet#33743
Did some profiling and all of the slowness is due to peverify. It seems to hit a wall about 700 levels of nesting. Once it's removed we can easily test our tolerance levels in the compiler
handle extension methods in "Sync Namespace" refactoring
…tch expression arm (dotnet#33697) * Correct parsing of a parenthesized constant pattern expression in switch expression arm Fixes dotnet#33675 * Add a test that we properly bind and code-gen a parenthesized constant expression.
Nullable nontrivial constructor should propagate state of the argument to Value.
Fix stack overflow compiling deeply nested generic
Check nullness of a nullable receiver when invoking base methods.
Have to disable quiet restore explicitly on local dev machines when doing a bootstrap build to work around this arcade issue: dotnet/arcade#2220
Merge dev16.0 to master
Merge dev16.0 to master
Fix local bootstrap build
Ref and out parameters with suppression should change the nullable state for the argument being suppressed. Moreover, the changes should flow through type inference. Closes dotnet#27743
AlekseyTs
added
Area-Compilers
PR For Personal Review Only
|
@dotnet/roslyn-compiler Need a sign-off for an integration PR. |
jcouv
approved these changes
Mar 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.