Remove legacy completion #38569

ivanbasov · 2019-09-07T00:36:57Z

No description provided.

src/EditorFeatures/Core.Wpf/Microsoft.CodeAnalysis.EditorFeatures.Wpf.csproj

CyrusNajmabadi · 2019-09-07T18:46:11Z

have not actually reviewed this. I presume it's just almost entirely the removal of the old code. so instead of looking at all that, was there anything more 'interesting' than that? if so, can you comment any areas that need particular attention? #Resolved

jinujoseph · 2019-09-08T23:14:57Z

cc @KirillOsenkov for info and review
cc @sandyarmstrong #Resolved

jasonmalinowski · 2019-09-09T16:51:47Z

@ivanbasov Can we target this at master? I recognize it'll create some merge conflicts into master-vs-deps, but does that make the code easier to maintain in master in the mean time? #Resolved

ivanbasov · 2019-09-09T17:59:28Z

@ivanbasov Can we target this at master? I recognize it'll create some merge conflicts into master-vs-deps, but does that make the code easier to maintain in master in the mean time?

Thank you, @jasonmalinowski ! Good idea! Let us meet merge conflict once, rather than supporting 2 branches for a longer time. Will rebase into master. #Resolved

ivanbasov · 2019-09-09T18:00:35Z

have not actually reviewed this. I presume it's just almost entirely the removal of the old code. so instead of looking at all that, was there anything more 'interesting' than that? if so, can you comment any areas that need particular attention?

Thank you, @CyrusNajmabadi ! I hope it is just a technical change: remove tests and remove the old implementation. I am not going to add anything interesting here. #Resolved

jasonmalinowski

Primary concern is there are some tests that didn't get switched back to Facts, and thus they won't run. I know @sharwell was discussing a bit getting some of the xunit analyzers running on VB as well....this might be a really good reason to do so since it'd be hugely easy to make more mistakes like that.

src/VisualStudio/Core/Test/Snippets/SnippetTestState.vb

src/VisualStudio/Core/Test/Completion/VisualBasicCompletionSnippetNoteTests.vb

src/VisualStudio/Core/Test/DebuggerIntelliSense/TestState.vb

src/VisualStudio/Core/Test/Snippets/SnippetTestState.vb

src/VisualStudio/Core/Test/DebuggerIntelliSense/TestState.vb

src/VisualStudio/Core/Test/Completion/CSharpCompletionSnippetNoteTests.vb

Co-Authored-By: Jason Malinowski <jason@jason-m.com>

ivanbasov · 2019-09-13T21:31:42Z

Feedback addressed. @jasonmalinowski and @sharwell please review/unblock #Resolved

Unblocking review as I won't have time to re-review.

sharwell · 2019-09-16T22:52:17Z

src/VisualStudio/IntegrationTest/TestUtilities/VisualStudioInstance.cs

@@ -304,12 +304,6 @@ private void StartRemoteIntegrationService(DTE dte)
            {
                dte.ExecuteCommand(WellKnownCommandNames.Test_IntegrationTestService_Start);
            }
-
-            if (AsyncCompletionCondition.Instance.ShouldSkip
-                && dte.Commands.Item(WellKnownCommandNames.Test_IntegrationTestService_DisableAsyncCompletion).IsAvailable)


❕ This command needs to be removed from WellKnownCommandNames and from the VSCT. #Resolved

📝 This is still problematic. Here are the locations I know need to be updated. There may be additional references that become obvious when you try to remove them.

roslyn/src/VisualStudio/IntegrationTest/TestSetup/IntegrationTestServiceCommands.vsct

Line 71 in 1689a20

<IDSymbol name="cmdidDisableAsyncCompletion" value="0x5203" />

roslyn/src/VisualStudio/IntegrationTest/TestSetup/IntegrationTestServiceCommands.vsct

Lines 46 to 54 in 1689a20

<Button guid="guidTestWindowCmdSet" id="cmdidDisableAsyncCompletion" priority="0x0030" type="Button">

<Parent guid="guidTestWindowCmdSet" id="grpidIntegrationTestService" />

<Strings>

<ButtonText>Disable Async Completion</ButtonText>

<CommandName>IntegrationTestService.DisableAsyncCompletion</CommandName>

<CanonicalName>IntegrationTestService.DisableAsyncCompletion</CanonicalName>

<LocCanonicalName>IntegrationTestService.DisableAsyncCompletion</LocCanonicalName>

</Strings>

</Button>

roslyn/src/VisualStudio/IntegrationTest/TestSetup/IntegrationTestServiceCommands.cs

Line 29 in 1689a20

public const int cmdidDisableAsyncCompletion = 0x5203;

roslyn/src/VisualStudio/IntegrationTest/TestSetup/IntegrationTestServiceCommands.cs

Lines 72 to 78 in 1689a20

var disableAsyncCompletionMenuCmdId = new CommandID(guidTestWindowCmdSet, cmdidDisableAsyncCompletion);

_disableAsyncCompletionMenuCmd = new MenuCommand(DisableAsyncCompletionCallback, disableAsyncCompletionMenuCmdId)

{

Enabled = true,

Visible = false,

};

menuCommandService.AddCommand(_disableAsyncCompletionMenuCmd);

roslyn/src/VisualStudio/IntegrationTest/TestSetup/IntegrationTestServiceCommands.cs

Line 43 in 1689a20

private readonly MenuCommand _disableAsyncCompletionMenuCmd;

roslyn/src/VisualStudio/IntegrationTest/TestSetup/IntegrationTestServiceCommands.cs

Lines 157 to 169 in 1689a20

private void DisableAsyncCompletionCallback(object sender, EventArgs e)

{

if (!_disableAsyncCompletionMenuCmd.Enabled)

{

return;

}

var componentModel = ServiceProvider.GetService<SComponentModel, IComponentModel>();

var featureServiceFactory = componentModel.GetService<IFeatureServiceFactory>();

featureServiceFactory.GlobalFeatureService.Disable(PredefinedEditorFeatureNames.AsyncCompletion, EmptyFeatureController.Instance);

_disableAsyncCompletionMenuCmd.Enabled = false;

}

#Resolved

src/VisualStudio/IntegrationTest/IntegrationTests/VisualBasic/BasicIntelliSense.cs

src/VisualStudio/IntegrationTest/IntegrationTests/CSharp/CSharpIntelliSense.cs

src/EditorFeatures/Core/Implementation/IntelliSense/AsyncCompletion/CommitManager.cs

src/EditorFeatures/Core/Implementation/IntelliSense/AsyncCompletion/CompletionSource.cs

src/VisualStudio/Core/Test/DebuggerIntelliSense/VisualBasicDebuggerIntellisenseTests.vb

src/VisualStudio/Core/Test/DebuggerIntelliSense/CSharpDebuggerIntellisenseTests.vb

src/EditorFeatures/Test2/IntelliSense/CSharpCompletionCommandHandlerTests.vb

- It's no longer possible to turn off async completion - Roslyn has already removed their legacy completion support: dotnet/roslyn#38569 - VS4Mac supports async completion. - This is required to target newer versions of Roslyn because they changed their legacy completion types.

ivanbasov added Area-IDE IDE-IntelliSense Completion, Signature Help, Quick Info labels Sep 7, 2019

ivanbasov added this to the 16.4 milestone Sep 7, 2019

ivanbasov requested review from genlu, sharwell and CyrusNajmabadi September 7, 2019 00:36

ivanbasov requested review from a team as code owners September 7, 2019 00:36

sharwell reviewed Sep 7, 2019

View reviewed changes

src/EditorFeatures/Core.Wpf/Microsoft.CodeAnalysis.EditorFeatures.Wpf.csproj Outdated Show resolved Hide resolved

ivanbasov added 4 commits September 9, 2019 11:26

remove implementation of the legacy completion

8d9556a

removing legacy completion from tests

f37e4c6

some tests fixed

e6c37d2

expect tests to pass. WIP

6632e02

ivanbasov changed the title ~~Remove legacy completion~~ WIP: Remove legacy completion Sep 9, 2019

ivanbasov changed the base branch from master-vs-deps to master September 9, 2019 18:31

ivanbasov force-pushed the removelegacy branch from 225bd4b to 6632e02 Compare September 9, 2019 18:31

fixing more tests

2d8e892

jasonmalinowski previously requested changes Sep 9, 2019

View reviewed changes

ivanbasov and others added 3 commits September 9, 2019 17:40

Update src/VisualStudio/Core/Test/Snippets/SnippetTestState.vb

3c262e8

Co-Authored-By: Jason Malinowski <jason@jason-m.com>

Update src/VisualStudio/Core/Test/DebuggerIntelliSense/TestState.vb

131ee6b

Co-Authored-By: Jason Malinowski <jason@jason-m.com>

Update src/VisualStudio/Core/Test/DebuggerIntelliSense/TestState.vb

3abd1ce

Co-Authored-By: Jason Malinowski <jason@jason-m.com>

This comment has been minimized.

Sign in to view

more fixed tests

c6f6b93

ivanbasov added 5 commits September 10, 2019 16:48

restoring custom commit

9da973f

more tests cases fixed: added snippet support

7e5cb0a

most of debugger tests fixed

c845207

hopefully all tests passed

2192ac7

feedback addressed

ca97691

ivanbasov changed the title ~~WIP: Remove legacy completion~~ Remove legacy completion Sep 13, 2019

ivanbasov added 2 commits September 13, 2019 15:01

more files to delete

5d70f15

unused field

1ef8905

sharwell reviewed Sep 16, 2019

View reviewed changes

src/VisualStudio/IntegrationTest/IntegrationTests/VisualBasic/BasicIntelliSense.cs Outdated Show resolved Hide resolved

sharwell reviewed Sep 16, 2019

View reviewed changes

src/VisualStudio/IntegrationTest/IntegrationTests/CSharp/CSharpIntelliSense.cs Outdated Show resolved Hide resolved

sharwell reviewed Sep 16, 2019

View reviewed changes

src/VisualStudio/IntegrationTest/IntegrationTests/CSharp/CSharpIntelliSense.cs Outdated Show resolved Hide resolved

sharwell reviewed Sep 17, 2019

View reviewed changes

src/EditorFeatures/Core/Implementation/IntelliSense/AsyncCompletion/CommitManager.cs Show resolved Hide resolved

sharwell reviewed Sep 17, 2019

View reviewed changes

src/EditorFeatures/Core/Implementation/IntelliSense/AsyncCompletion/CompletionSource.cs Show resolved Hide resolved

sharwell reviewed Sep 17, 2019

View reviewed changes

src/VisualStudio/Core/Test/DebuggerIntelliSense/VisualBasicDebuggerIntellisenseTests.vb Outdated Show resolved Hide resolved

sharwell reviewed Sep 17, 2019

View reviewed changes

src/VisualStudio/Core/Test/DebuggerIntelliSense/CSharpDebuggerIntellisenseTests.vb Outdated Show resolved Hide resolved

feedback addressed

b6fe4cc

sharwell reviewed Sep 18, 2019

View reviewed changes

src/EditorFeatures/Test2/IntelliSense/CSharpCompletionCommandHandlerTests.vb Show resolved Hide resolved

ivanbasov mentioned this pull request Sep 18, 2019

disable old completion: PR for test only. not for commit #33616

Closed

code review feedback

8af40a5

sharwell approved these changes Sep 19, 2019

View reviewed changes

ivanbasov merged commit cf78aee into dotnet:master Sep 19, 2019

ivanbasov deleted the removelegacy branch September 19, 2019 04:31

NTaylorMullen mentioned this pull request Nov 5, 2019

Remove legacy Razor directive completion dotnet/razor#1288

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove legacy completion #38569

Remove legacy completion #38569

ivanbasov commented Sep 7, 2019

CyrusNajmabadi commented Sep 7, 2019 •

edited by ivanbasov

Loading

jinujoseph commented Sep 8, 2019 •

edited by ivanbasov

Loading

jasonmalinowski commented Sep 9, 2019 •

edited by ivanbasov

Loading

ivanbasov commented Sep 9, 2019 •

edited

Loading

ivanbasov commented Sep 9, 2019 •

edited

Loading

jasonmalinowski left a comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ivanbasov commented Sep 13, 2019 •

edited

Loading

sharwell Sep 16, 2019 •

edited by ivanbasov

Loading

sharwell Sep 18, 2019 •

edited by ivanbasov

Loading

	<Button guid="guidTestWindowCmdSet" id="cmdidDisableAsyncCompletion" priority="0x0030" type="Button">
	<Parent guid="guidTestWindowCmdSet" id="grpidIntegrationTestService" />
	<Strings>
	<ButtonText>Disable Async Completion</ButtonText>
	<CommandName>IntegrationTestService.DisableAsyncCompletion</CommandName>
	<CanonicalName>IntegrationTestService.DisableAsyncCompletion</CanonicalName>
	<LocCanonicalName>IntegrationTestService.DisableAsyncCompletion</LocCanonicalName>
	</Strings>
	</Button>

	var disableAsyncCompletionMenuCmdId = new CommandID(guidTestWindowCmdSet, cmdidDisableAsyncCompletion);
	_disableAsyncCompletionMenuCmd = new MenuCommand(DisableAsyncCompletionCallback, disableAsyncCompletionMenuCmdId)
	{
	Enabled = true,
	Visible = false,
	};
	menuCommandService.AddCommand(_disableAsyncCompletionMenuCmd);

	private void DisableAsyncCompletionCallback(object sender, EventArgs e)
	{
	if (!_disableAsyncCompletionMenuCmd.Enabled)
	{
	return;
	}

	var componentModel = ServiceProvider.GetService<SComponentModel, IComponentModel>();
	var featureServiceFactory = componentModel.GetService<IFeatureServiceFactory>();
	featureServiceFactory.GlobalFeatureService.Disable(PredefinedEditorFeatureNames.AsyncCompletion, EmptyFeatureController.Instance);

	_disableAsyncCompletionMenuCmd.Enabled = false;
	}

Remove legacy completion #38569

Remove legacy completion #38569

Conversation

ivanbasov commented Sep 7, 2019

CyrusNajmabadi commented Sep 7, 2019 • edited by ivanbasov Loading

jinujoseph commented Sep 8, 2019 • edited by ivanbasov Loading

jasonmalinowski commented Sep 9, 2019 • edited by ivanbasov Loading

ivanbasov commented Sep 9, 2019 • edited Loading

ivanbasov commented Sep 9, 2019 • edited Loading

jasonmalinowski left a comment

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ivanbasov commented Sep 13, 2019 • edited Loading

sharwell Sep 16, 2019 • edited by ivanbasov Loading

Choose a reason for hiding this comment

sharwell Sep 18, 2019 • edited by ivanbasov Loading

Choose a reason for hiding this comment

CyrusNajmabadi commented Sep 7, 2019 •

edited by ivanbasov

Loading

jinujoseph commented Sep 8, 2019 •

edited by ivanbasov

Loading

jasonmalinowski commented Sep 9, 2019 •

edited by ivanbasov

Loading

ivanbasov commented Sep 9, 2019 •

edited

Loading

ivanbasov commented Sep 9, 2019 •

edited

Loading

ivanbasov commented Sep 13, 2019 •

edited

Loading

sharwell Sep 16, 2019 •

edited by ivanbasov

Loading

sharwell Sep 18, 2019 •

edited by ivanbasov

Loading