Change IEnumerable to ImmutableArray #50323
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwengier
approved these changes
Jan 8, 2021
| /// <summary> | ||
| /// Gets all source generated documents in this project. | ||
| /// </summary> | ||
| public async ValueTask<ImmutableArray<SourceGeneratedDocument>> GetSourceGeneratedDocumentsAsync(CancellationToken cancellationToken = default) |
There was a problem hiding this comment.
Do we have an interface to return that is immutable but not directly ImmutableArray? I worry if we end up with projects with thousands of generated files whether the larger arrays will cause issues.
There was a problem hiding this comment.
(and yes the implementation would need some tweaking in that case, but at least we're not locked in with the current signature)
There was a problem hiding this comment.
You mean we would not want to instantiate all of the SourceGeneratedDocuments?
|
Gonna keep this IEnumerable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unshipped public API change
Return
ImmutableArrayinstead ofIEnumerablefromGetSourceGeneratedDocumentsAsync