EnC - Update CustomAttributes table instead of just always adding to it

[davidwengier]

Fixes #52816

This doesn't do anything for deletes yet, need to decide if we will, and how. Previously we didn't care about changes that were only visible through reflection, but now that reflection caches are cleared that maybe isn't fair. Though re-orders then probably need to be changed too? Need to discuss.

[davidwengier]

@tmat given dotnet/runtime#53066 I wonder if this change in behaviour should be based on the runtime capabilities, so that downlevel frameworks aren't affected? I don't think its an enourmous issue since the issue already exists in those frameworks, so its probably not causing issues due to reflection caching, but the most cautious approach would be to only change behaviour for .NET 6 and up.

[davidwengier]

Apologies @tmat that you had to read all of that, the new code with binary search is much simpler, much easier to understand, and was much easier to write.

[tmat]

add

Isn't this rather "update" then "add"?

[davidwengier]

Naming on this one was hard. It either adds an EncLog entry, or it creates a "delete" custom attribute and adds it to the list for later emitting.

[tmat]

[tmat]

🕐

[tmat]

[davidwengier]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[davidwengier]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).