Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EnC: A couple of small fixes #62454

Merged
merged 4 commits into from
Jul 13, 2022
Merged

EnC: A couple of small fixes #62454

merged 4 commits into from
Jul 13, 2022

Conversation

tmat
Copy link
Member

@tmat tmat commented Jul 7, 2022

No description provided.

@tmat tmat changed the title Partially loaded projects EnC: Handle partially loaded projects Jul 7, 2022
@tmat tmat force-pushed the PartiallyLoadedProjects branch from bd9aaca to 1d9aa91 Compare July 8, 2022 16:15
@tmat tmat marked this pull request as ready for review July 11, 2022 16:13
@tmat tmat requested a review from a team as a code owner July 11, 2022 16:13
@tmat tmat marked this pull request as draft July 11, 2022 16:14
@tmat tmat changed the title EnC: Handle partially loaded projects EnC: A couple of small fixes Jul 11, 2022
@tmat
Copy link
Member Author

tmat commented Jul 12, 2022

@davidwengier PTAL

@tmat tmat marked this pull request as ready for review July 13, 2022 17:48
@tmat tmat enabled auto-merge (squash) July 13, 2022 21:57
@tmat tmat merged commit 9bea1cd into dotnet:main Jul 13, 2022
@ghost ghost added this to the Next milestone Jul 13, 2022
333fred added a commit to 333fred/roslyn that referenced this pull request Jul 14, 2022
* upstream/main:
  Bind IterationErrorVariable to a natural type for error recovery (dotnet#62601)
  [main] Update dependencies from dotnet/source-build-externals (dotnet#61173)
  Cleanup: remove VisualStudioWorkspaceImpl.TryGetContainedDocument (dotnet#62616)
  EnC: A couple of small fixes (dotnet#62454)
  Report error for ref field declared in type other than ref struct (dotnet#62615)
  Store helpful info needed by incremental-generation on syntax-tree itself (dotnet#62551)
adamperlin pushed a commit to adamperlin/roslyn that referenced this pull request Jul 19, 2022
* Use NoCompilationLanguageService instead of a custom one in EnC tests

* SupportsEditAndContinue asserts

* Do not cache failures to read MVID

* Feedback
@allisonchou allisonchou modified the milestones: Next, 17.4 P1 Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants