Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report error for ref field declared in type other than ref struct #62615

Merged
merged 3 commits into from
Jul 13, 2022
Merged

Report error for ref field declared in type other than ref struct #62615

merged 3 commits into from
Jul 13, 2022

Conversation

cston
Copy link
Member

@cston cston commented Jul 13, 2022

Fixes #62596

@cston cston requested a review from a team as a code owner July 13, 2022 19:16
@RikkiGibson
Copy link
Contributor

it's seriously the most mundane things we end up missing..

@jcouv jcouv self-assigned this Jul 13, 2022
@jcouv
Copy link
Member

jcouv commented Jul 13, 2022

Let's spend the time to scan and check the test plan: #59194

jcouv
jcouv approved these changes Jul 13, 2022
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 2)

@cston cston merged commit 99cc46f into dotnet:main Jul 13, 2022
@cston cston deleted the 62596 branch July 13, 2022 23:14
@ghost ghost added this to the Next milestone Jul 13, 2022
333fred added a commit to 333fred/roslyn that referenced this pull request Jul 14, 2022
@333fred
Merge remote-tracking branch 'upstream/main' into forbid-inumber
5420492 
* upstream/main:
  Bind IterationErrorVariable to a natural type for error recovery (dotnet#62601)
  [main] Update dependencies from dotnet/source-build-externals (dotnet#61173)
  Cleanup: remove VisualStudioWorkspaceImpl.TryGetContainedDocument (dotnet#62616)
  EnC: A couple of small fixes (dotnet#62454)
  Report error for ref field declared in type other than ref struct (dotnet#62615)
  Store helpful info needed by incremental-generation on syntax-tree itself (dotnet#62551)
adamperlin pushed a commit to adamperlin/roslyn that referenced this pull request Jul 19, 2022
@cston @adamperlin
Report error for ref field declared in type other than ref struct (do…
cc689ff 
…tnet#62615)
@allisonchou allisonchou modified the milestones: Next, 17.4 P1 Jul 26, 2022
@ryzngard ryzngard mentioned this pull request Jul 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RikkiGibson RikkiGibson RikkiGibson approved these changes

@jcouv jcouv jcouv approved these changes

Assignees

@jcouv jcouv

Labels
Area-Compilers New Language Feature - Ref Fields
Projects
None yet
Milestone
17.4 P1
Development

Successfully merging this pull request may close these issues.

No error for ref fields in non-ref structs
4 participants
@cston @RikkiGibson @jcouv @allisonchou