Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix main failure #62833

Closed
wants to merge 3 commits into from
Closed

Fix main failure #62833

wants to merge 3 commits into from

Conversation

Youssef1313
Copy link
Member

Two conflicting PRs of mine were merged. One that adds a reference to ILanguageSpecificOption and one that renames it to ISingleValuedOption.

The change here is also included in #62826, so if #62826 got merged first, this PR should be closed.

@Youssef1313 Youssef1313 requested a review from a team as a code owner July 21, 2022 14:42
@ghost ghost added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Jul 21, 2022
@Youssef1313
Copy link
Member Author

@davidwengier There are EnC failures. Can you take a look please?

@Youssef1313
Copy link
Member Author

Youssef1313 commented Jul 21, 2022 •
edited
Loading

I assume these are related to the recently merged PR #62364 (but not sure how CI passed in #62364)

@RikkiGibson RikkiGibson requested a review from a team July 21, 2022 19:12
@RikkiGibson RikkiGibson added Area-Infrastructure Priority:0 Work that we can't release without labels Jul 21, 2022
@CyrusNajmabadi CyrusNajmabadi mentioned this pull request Jul 21, 2022
Closed
@CyrusNajmabadi
Copy link
Member

We will likely take #62843 it passes. If it does not, we can take this.

@CyrusNajmabadi CyrusNajmabadi mentioned this pull request Jul 21, 2022
Merged
@CyrusNajmabadi
Copy link
Member

Closing out as we took the other PR. Thankjs!

@Youssef1313 Youssef1313 deleted the patch-20 branch July 21, 2022 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

Assignees
No one assigned
Labels
Area-IDE Area-Infrastructure Community The pull request was submitted by a contributor who is not a Microsoft employee. Priority:0 Work that we can't release without
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Youssef1313 @CyrusNajmabadi @RikkiGibson