Fixes bad merge #62843
Merged
Fixes bad merge #62843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youssef1313
reviewed
Jul 21, 2022
| @@ -3943,7 +3943,8 @@ End Class | |||
| { | |||
| SemanticEdit(SemanticEditKind.Update, Function(c) c.GetMember("C.F1")) | |||
| }) | |||
| }) | |||
| }, | |||
| capabilities:=EditAndContinueCapabilities.AddMethodToExistingType) | |||
There was a problem hiding this comment.
Is it known why these tests originally passed in #62364?
There was a problem hiding this comment.
Thank you for fixing this. Seems like my last push didn't kick off a build for some reason.
CyrusNajmabadi
approved these changes
Jul 21, 2022
ryzngard
approved these changes
Jul 21, 2022
Closed
|
We should take this if it passes. If not, we should take #62833 |
RikkiGibson
approved these changes
Jul 21, 2022
allisonchou
approved these changes
Jul 21, 2022
ghost
added this to the 
|
Opened dotnet/arcade#10118 to track further instances of the root problem which necessitated this fix. |
This was referenced Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.