Expose WorkspaceKind off of Solution snapshot instance #62913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
genlu
approved these changes
Jul 25, 2022
ghost
added this to the 
tmat
reviewed
Jul 25, 2022
| @@ -150,6 +154,8 @@ public SolutionState WithNewWorkspace(Workspace workspace, int workspaceVersion) | |||
|
|
|||
| public ImmutableDictionary<ProjectId, ProjectState> ProjectStates => _projectIdToProjectStateMap; | |||
|
|
|||
| public string? WorkspaceKind { get; } | |||
This was referenced Jul 28, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps the effort to stop exposing the Workspace off of a solution snapshot.
We intend to add solutionInstance.Workspace to the banned api list for roslyn itself. It's highly problematic for OOP, as we have to try to replicate that concept, which isn't something sensical in that world. First, OOP cannot mutation things, so exposing the mutable workspace doesn't make much sense. Second, in VS you can have many workspaces, but in OOP we map that all back to one, which means we don't have a proper representation of VS state (for example, where you might have the VSWorkspace and the Metadata-as-source workspace). This means those features either cannot use OOP, or they try to use OOP and can end up with non-sensical results.
This is a series of PRs to get us off of that API so we can move to a much cleaner and simpler OOP model for the solution and services.