Convert workspaces and new document formatting integration tests to new framework #63610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dibarbet
commented
Aug 26, 2022
| @@ -65,9 +66,7 @@ public static string GetStringFromBulkContent(IEnumerable<object> content) | |||
| private static string GetStringFromTextBlock(TextBlock textBlock) | |||
| { | |||
| if (!string.IsNullOrEmpty(textBlock.Text)) | |||
| { | |||
There was a problem hiding this comment.
this appears to have been autoformatted after changing the namespace
dibarbet
changed the title
|
Ended up disabling the new doc formatting tests - they are still hitting restore issues consistently on CI (though I've never hit it locally even on 100 iterations on my machine). In order to move integration tests forward to the scouting queue I've disabled them |
This was referenced Aug 26, 2022
dibarbet
force-pushed
the
dev/dibarbet/convert_integration_tests
branch
3 times, most recently
from
f06b026
to
af38f19
Compare
dibarbet
force-pushed
the
dev/dibarbet/convert_integration_tests
branch
from
af38f19
to
ea12594
Compare
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were having restore issues in the scouting queue on the old framework. Running them locally showed that the new framework is much less flaky.
Also appears to resolve #34264