Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unskip error list tests #63623

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

dibarbet
Copy link
Member

@dibarbet dibarbet commented Aug 26, 2022

Verifying on scouting queue (17.4p1) that these test pass

Resolves #61367

Need to re-run after #63610

@dibarbet dibarbet force-pushed the dev/dibarbet/reenable_errorlist_tests branch from d79f4b3 to 0b838cc Compare August 26, 2022 19:25
@dibarbet
Copy link
Member Author

Closing, still flaky. Failed 1/10 iterations with

Actual and expected values differ. Expected shown in baseline of diff:
+(Compiler) Class1.cs(2, 7): error CS0518: Predefined type 'System.Object' is not defined or imported
+(Compiler) Class1.cs(2, 7): error CS1729: 'object' does not contain a constructor that takes 0 arguments
(Compiler) Class1.cs(4, 12): error CS0246: The type or namespace name 'P' could not be found (are you missing a using directive or an assembly reference?)
-(Compiler) Class1.cs(6, 24): error CS0117: 'Console' does not contain a definition for 'WriteLin'
+(Compiler) Class1.cs(4, 12): error CS0518: Predefined type 'System.Object' is not defined or imported
+(Compiler) Class1.cs(4, 5): error CS0518: Predefined type 'System.Void' is not defined or imported
+(Compiler) Class1.cs(6, 9): error CS0103: The name 'System' does not exist in the current context
+(Compiler) Class1.cs(6, 9): error CS0518: Predefined type 'System.Object' is not defined or imported
+(Compiler) Class1.cs(9, 12): error CS0518: Predefined type 'System.Void' is not defined or imported
+(Compiler) Class1.cs(9, 22): error CS0518: Predefined type 'System.String' is not defined or imported

Expected: True
Actual:   False

https://dev.azure.com/dnceng-public/public/_build/results?buildId=79311&view=ms.vss-test-web.build-test-results-tab&runId=1658296&resultId=100580&paneView=debug

@dibarbet dibarbet closed this Nov 10, 2022
@sharwell sharwell reopened this Nov 2, 2023
@sharwell
Copy link
Member

sharwell commented Nov 2, 2023

Reopened this so the tests will run again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

roslyn.visualstudio.newintegrationtests.csharp.csharperrorlistnetcore.errorlist
3 participants