Improve error recovery while parsing switch expressions. #67340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RikkiGibson @jjonescz ptal. |
333fred
reviewed
Mar 17, 2023
src/Compilers/CSharp/Test/Syntax/Parsing/SwitchExpressionParsingTests.cs
Show resolved
Hide resolved
If at the point i run into that problem, i'd be happy to contribute more. But i really have to timebox these things to prevent feature creep and just not having enough time for these improvements and the rest of hte stuff on my plate. For thigns like error recovery, we could spend unlimited time on things, so i'd really like to keep things targetted and specific so it's easy to make the change, test and review all at once :) |
333fred
approved these changes
Mar 17, 2023
|
@RikkiGibson @jjonescz ptal. Thanks! :) |
RikkiGibson
reviewed
Mar 17, 2023
src/Compilers/CSharp/Portable/Parser/LanguageParser_Patterns.cs
Outdated
Show resolved
Hide resolved
RikkiGibson
reviewed
Mar 17, 2023
src/Compilers/CSharp/Test/Syntax/Parsing/SwitchExpressionParsingTests.cs
Outdated
Show resolved
Hide resolved
RikkiGibson
reviewed
Mar 17, 2023
src/Compilers/CSharp/Test/Syntax/Parsing/SwitchExpressionParsingTests.cs
Outdated
Show resolved
Hide resolved
RikkiGibson
approved these changes
Mar 17, 2023
|
Really nice improvement. Thanks! |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, the parser tends to go off the rails when manually converting a switch statemnt to a switch expression. This makes the parser much better behaved, preventing lots of cascading errors.