Snap 17 7 #67968
Merged
Snap 17 7 #67968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pool more formatting collections
* Avoid realizing SyntaxReference[] in source methods * Update fields as well
…sions. (dotnet#67773) * Continued removal of location allocations * Continued removal of location allocations * Only compute once * Defer location allocation * Defer more location creation * Apply suggestions from code review * Update src/Compilers/CSharp/Portable/Binder/Binder.cs * Remove unnecessary loc allocs * Revert * revert * revert * revert
…tnet#67461) * Allow nested instance member access in 'nameof' in static context Co-authored-by: Yair Halberstadt <yairh@google.com> * Make feature name more specific * Remove redundant check * Test more versions * Reuse expected diagnostics * Add symbol info tests * Add IOperation tests * Reuse existing helper * Add completion tests * Test lambdas and local functions * Test data flow --------- Co-authored-by: Yair Halberstadt <yairh@google.com>
Incrementally update dependency graph for new cases
* Source build fixes The source build produced from our official build needs to include both the net7.0 and net8.0 packages. Those packages feed into the soucre build legs of other repos and they can be targeting either net7.0 or net8.0. * fixes * Fix Work around a bug in the public API analyzer dotnet/roslyn-analyzers#6059 * nint * fix package * fix
* In progress * Move to local function * Make satic * Pull worklist up
Eliminate intermediate pooling in CreateNodeOperations
…edDocumentOnce Only modify the linked document once in LSP code action
Add ServerGC option
Reduce allocations in 'add import'.
* Fixing source build The Microsoft.Net.Compilers.Toolset package produced from our source build CI leg is the toolset used by other repos as part of their CI build. Those legs can be running on a previous or current .NET SDK / runtime. That means to workin all scenarios our toolset package in the CI leg must target previous runtime / SDK. This is starting to produce an unwieldy amount of MSBuild properties for our target frameworks. I decided to remove the `NetFx` one to cut down on the complexity a bit. Source build already has solutions for stripping out `net472`. For the moment removing our custom solution to simplify a bit so I can get source build off the floor. Can revisit once we get back to a clean state. * pr feedback * unblock dev builds
Add A/B option to test if disabling 'recoverable text' helps/hurts us
…onsecutiveIfStatementCodeRefactoringProvider
…utiveIfStatementCodeRefactoringProvider Fix a wrong text span usage in MergeIfStatementsCodeRefactoringProvider
Add a helper diagnostic for enforcing IDE0005 (remove unnecessary usi…
…agnostics Allow code fixes for source generator diagnostics
* In progress * Simplify * Simplify * no dispose
Move to non-segmented dictionary
Add import completion option to LSP
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
CyrusNajmabadi
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.