Update interceptors branch from latest main #68182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dev/shech/CheckConfigurationCapability
…ionCapability [17.6] Only send workspace/configuration request when client supports that
EnC telemetry improvements
…match (dotnet#66992) * Add tests * Check count before reusing batched items * Add missing assert * Fix local function name casing * Fix notation in comment * Revert "Check count before reusing batched items" This reverts commit 2984b5f. * Check state table counts before caching * Clarify doc comment * Add a test Co-authored-by: Chris Sienkiewicz <chsienki@microsoft.com> * Compute `IsCached` flag only in the builder --------- Co-authored-by: Chris Sienkiewicz <chsienki@microsoft.com>
* Use exception with specific type and HResult to aid tracking in telemetry * Associate rude edits with project id
* Check if DocCookie is int instead of uint * Make doc cookie cast more resilient
…ptionsChange Add RequiresNonDocumentChangesTag to ProjectOptionsChangeAction
…med-types and methods. (dotnet#68131) * Use a singleton for empty type-parameters for named types * move type parameters down * Optimize methods as well * Always create indirection * Move type * Apply suggestions from code review * speeling * nrt * Inline * Simplify * Change to abstract override
* Record added node output states as new The `(EntryState.Modified, EntryState.Added) => IncrementalStepRunReason.Modified` state mapping was recently added in dotnet#61308, but doesn't look correct to me. Since this value is used as the output status, and the outputs are new, I believe the correct state should be `IncrementalStepRunReason.New` instead. * Update tests that were added since I originally implemented the change * Update documentation for IncrementalStepRunReason * Update VB tests also * Add note about breaking changes with IncrementalStepRunReason --------- Co-authored-by: Jan Jones <janjones@microsoft.com>
* Add a test * Display standalone parameter names by default * Document breaking change * Update tests
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
cston
approved these changes
May 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual conflict resolutions in 9e251f6