Change how creation dates are specified in the SG api #72794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
Mar 28, 2024
| Checksum solutionChecksum, ProjectId projectId, CancellationToken cancellationToken); | ||
|
|
||
| /// <summary> | ||
| /// Given a particular set of generated document ids, returns the fully generated content for those documents. | ||
| /// Should only be called by the host for documents it does not know about, or documents whose checksum contents are | ||
| /// different than the last time the document was queried. | ||
| /// </summary> | ||
| ValueTask<ImmutableArray<(string contents, DateTime generationDateTime)>> GetContentsAsync( | ||
| ValueTask<ImmutableArray<string>> GetContentsAsync( |
There was a problem hiding this comment.
this value moved from the content request (which is really just about getting the excat content for a checksum) to the above call to get info about a generated file. THat's not only better, it's more correct as we can def be in a situation where we say "we generated the same contents in OOP as last time, but the generation timestamps were incremented".
CyrusNajmabadi
commented
Mar 28, 2024
| this.SourceText, | ||
| this.LoadTextOptions, | ||
| this.TreeSource!, | ||
| this._lazyContentHash, | ||
| generationDateTime); |
There was a problem hiding this comment.
previously, updating the generation-time would cause the doc to be reparsed. there's no need for that at all.
|
@jasonmalinowski For review when you get back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #72494