Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build warnings observed locally #73593

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Conversation

sharwell
Copy link
Member

No description provided.

@sharwell sharwell requested review from a team as code owners May 20, 2024 19:39
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels May 20, 2024

<!--
Make sure the _GetPackageFiles target exists, since it is always expected for design time builds, but only
defined when ImportNuGetBuildTasksPackTargetsFromSdk is true.
Copy link
Member

@dibarbet dibarbet May 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you know when this is not true?

Wondering if the import of this file can be conditioned on the existence of the target or related condition - https://github.com/dotnet/roslyn/blob/main/src/Features/LanguageServer/Microsoft.CodeAnalysis.LanguageServer/Microsoft.CodeAnalysis.LanguageServer.csproj#L142

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't make a note of this at the time, but it may be related to this:

<ImportNuGetBuildTasksPackTargetsFromSdk>false</ImportNuGetBuildTasksPackTargetsFromSdk>

<ExcludeFromSourceBuild>true</ExcludeFromSourceBuild>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.NETFramework.ReferenceAssemblies.net45" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need the net45 reference assemblies and not e.g. the net472 ones?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, but this fixes the issue.

@sharwell sharwell merged commit 9aea809 into dotnet:main Jun 10, 2024
28 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Jun 10, 2024
@sharwell sharwell deleted the build-warnings branch June 10, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants