Optimization of (de)serialization of ProjectId.DebugNames #73734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This string was showing up as about 3% in both serialization and deserialization during a find all references operation.
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
ToddGrun
changed the title
3 tasks
CyrusNajmabadi
approved these changes
May 28, 2024
src/Workspaces/Remote/Core/Serialization/MessagePackFormatters.cs
Outdated
Show resolved
Hide resolved
| // This ProjectId has previously been deserialized. Attempt to find it's | ||
| // debugName from the cache. This *should* always succeed, but if not, it's | ||
| // ok to proceed with a null debugName. | ||
| _debugNames.TryGetValue(id, out debugName); |
There was a problem hiding this comment.
Don't love this. But I'm willing to try it out. Seems like we could have a small race where some IDs don't have a debug name. But ideally it's a very small amount.
There was a problem hiding this comment.
I changed this a bit in the second commit to replace the value in the cache if we receive a subsequent message that contains the debug name
CyrusNajmabadi
approved these changes
May 28, 2024
This was referenced Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This string was showing up in traces for both serialization and deserialization during a find all references operation.
*** VS, before ***
*** VS, after ***
*** OOP, before ***
*** OOP, after ***
