Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test certs that don't use RC2 to System.Net.TestData and System.Security.Cryptography.X509Certificates.TestData #120

Merged
merged 1 commit into from
Mar 9, 2021

Conversation

elinor-fung
Copy link
Member

Created by importing the original certs (that use RC2) on Windows and re-exporting them to generate versions without RC2.

cc @jkoritzinsky @steveisok @AaronRobinsonMSFT @bartonjs @wfurt

System.Security.Cryptography.X509Certificates.TestData
@bartonjs
Copy link
Member

bartonjs commented Mar 8, 2021

The diff view says all the new files are empty, instead of added as binary files.

@elinor-fung
Copy link
Member Author

Do I need to do something special to add them differently?
If I go to 'view file' in the diff, it does show the size and I can download the (non-empty) binary file.

@bartonjs
Copy link
Member

bartonjs commented Mar 8, 2021

Must be a UI bug, then.

I don't know how new packages get published from here... so I'm not sure how we'll consume it from the tests.

@elinor-fung
Copy link
Member Author

My understanding is that once this goes in, a CI build will publish the new packages. The runtime repo subscribes to this as a dependency, so a PR should automatically be opened to update to the new package versions. And once that goes in, we can consume the new files from the tests.

@jkoritzinsky
Copy link
Member

Elinor's description is correct. We should get a package with the updated data files within about a day at max automatically consumed in dotnet/runtime.

@bartonjs
Copy link
Member

bartonjs commented Mar 8, 2021

Oh, nice. The last time I updated this package it involved a lot of tracking people down for manual builds and uploads 😄.

And all of this was fields. And I had to walk to school barefoot. In the snow. Uphill. Both ways.

@elinor-fung elinor-fung merged commit c7c1481 into dotnet:main Mar 9, 2021
@elinor-fung elinor-fung deleted the testCerts-noRC2 branch March 9, 2021 00:39
@danmoseley
Copy link
Member

cc @aik-jahoda

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants