Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Perf] Windows/x64: Multiple (13) Regressions on 11/14/2024 12:52:44 AM #109967

Open
performanceautofiler bot opened this issue Nov 19, 2024 · 2 comments
Open

[Perf] Windows/x64: Multiple (13) Regressions on 11/14/2024 12:52:44 AM #109967

performanceautofiler bot opened this issue Nov 19, 2024 · 2 comments
Assignees
@noahfalk @LoopedBard3
Labels
arch-x64 area-Diagnostics-coreclr os-windows runtime-coreclr specific to the CoreCLR runtime tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark
Milestone
10.0.0

Comments

@performanceautofiler
Copy link

Run Information

Name Value
Architecture x64
OS Windows 10.0.22621
Queue TigerWindows
Baseline d3d0fced1d125483d668bef176618e6a805cb2bd
Compare 1e98c05201e3c8df70b0334ce1d4a28cfe2b3c26
Diff Diff
Configs CompilationMode:tiered, RunKind:micro

Regressions in System.Collections.TryGetValueTrue<BigStruct, BigStruct>

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio
471.99 μs 517.46 μs 1.10 0.02 True
483.59 μs 521.79 μs 1.08 0.02 True
475.34 μs 527.66 μs 1.11 0.02 True
464.58 μs 513.10 μs 1.10 0.02 True
483.38 μs 538.79 μs 1.11 0.02 True

Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Collections.TryGetValueTrue&lt;BigStruct, BigStruct&gt;*'

System.Collections.TryGetValueTrue<BigStruct, BigStruct>.FrozenDictionaryOptimized(Size: 512)

ETL Files

Histogram

JIT Disasms

System.Collections.TryGetValueTrue<BigStruct, BigStruct>.Dictionary(Size: 512)

ETL Files

Histogram

JIT Disasms

System.Collections.TryGetValueTrue<BigStruct, BigStruct>.IDictionary(Size: 512)

ETL Files

Histogram

JIT Disasms

System.Collections.TryGetValueTrue<BigStruct, BigStruct>.ConcurrentDictionary(Size: 512)

ETL Files

Histogram

JIT Disasms

System.Collections.TryGetValueTrue<BigStruct, BigStruct>.ImmutableDictionary(Size: 512)

ETL Files

Histogram

JIT Disasms

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

Run Information

Name Value
Architecture x64
OS Windows 10.0.22621
Queue TigerWindows
Baseline d3d0fced1d125483d668bef176618e6a805cb2bd
Compare d3f4de1c7ab45eda70f2e084c3b47a38cfca8d74
Diff Diff
Configs CompilationMode:tiered, RunKind:micro

Regressions in System.Reflection.Invoke

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio
42.55 ns 47.16 ns 1.11 0.02 False
41.45 ns 45.79 ns 1.10 0.02 False
38.58 ns 43.33 ns 1.12 0.04 False
39.82 ns 44.31 ns 1.11 0.07 False

Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Reflection.Invoke*'

System.Reflection.Invoke.Field_Get_int

ETL Files

Histogram

JIT Disasms

System.Reflection.Invoke.Field_Get_struct

ETL Files

Histogram

JIT Disasms

System.Reflection.Invoke.Field_GetStatic_struct

ETL Files

Histogram

JIT Disasms

System.Reflection.Invoke.Field_GetStatic_int

ETL Files

Histogram

JIT Disasms

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

Run Information

Name Value
Architecture x64
OS Windows 10.0.22621
Queue TigerWindows
Baseline d3d0fced1d125483d668bef176618e6a805cb2bd
Compare d3f4de1c7ab45eda70f2e084c3b47a38cfca8d74
Diff Diff
Configs CompilationMode:tiered, RunKind:micro

Regressions in System.Diagnostics.Perf_Process

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio
102.88 ns 109.55 ns 1.06 0.00 False

Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Diagnostics.Perf_Process*'

System.Diagnostics.Perf_Process.GetCurrentProcess

ETL Files

Histogram

JIT Disasms

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

Run Information

Name Value
Architecture x64
OS Windows 10.0.22621
Queue TigerWindows
Baseline d3d0fced1d125483d668bef176618e6a805cb2bd
Compare d3f4de1c7ab45eda70f2e084c3b47a38cfca8d74
Diff Diff
Configs CompilationMode:tiered, RunKind:micro

Regressions in System.Tests.Perf_Array

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio
1.56 ms 1.77 ms 1.14 0.03 False
1.73 ms 1.95 ms 1.13 0.01 False
1.98 ms 2.24 ms 1.13 0.02 False

Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Tests.Perf_Array*'

System.Tests.Perf_Array.ArrayRetrieve1D

ETL Files

Histogram

JIT Disasms

System.Tests.Perf_Array.ArrayRetrieve2D

ETL Files

Histogram

JIT Disasms

System.Tests.Perf_Array.ArrayRetrieve3D

ETL Files

Histogram

JIT Disasms

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
@performanceautofiler performanceautofiler bot added arch-x64 os-windows runtime-coreclr specific to the CoreCLR runtime untriaged New issue has not been triaged by the area owner labels Nov 19, 2024
@performanceautofiler performanceautofiler bot mentioned this issue Nov 19, 2024
Closed
@LoopedBard3 LoopedBard3 transferred this issue from dotnet/perf-autofiling-issues Nov 19, 2024
@LoopedBard3 LoopedBard3 self-assigned this Nov 19, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Nov 19, 2024
@LoopedBard3 LoopedBard3 added tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark and removed os-windows arch-x64 untriaged New issue has not been triaged by the area owner runtime-coreclr specific to the CoreCLR runtime needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Nov 19, 2024
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Nov 19, 2024
@LoopedBard3
Copy link
Member

LoopedBard3 commented Nov 19, 2024 •
edited
Loading

Only one commit in the main regression range: #104955 FYI @noahfalk. Is there any expectation of impact to microbenchmarks from this change? If not, may have disturbed optimization.

Related Regressions:
Linux x64: dotnet/perf-autofiling-issues#45061, dotnet/perf-autofiling-issues#45032, dotnet/perf-autofiling-issues#45060
Windows x64: dotnet/perf-autofiling-issues#45042, dotnet/perf-autofiling-issues#45070
Windows arm64: dotnet/perf-autofiling-issues#45595, dotnet/perf-autofiling-issues#45596, dotnet/perf-autofiling-issues#46030, dotnet/perf-autofiling-issues#46028, dotnet/perf-autofiling-issues#46026

@LoopedBard3 LoopedBard3 changed the title [Perf] Windows/x64: 13 Regressions on 11/14/2024 12:52:44 AM [Perf] Windows/x64: Multiple (13) Regressions on 11/14/2024 12:52:44 AM Nov 19, 2024
@LoopedBard3 LoopedBard3 added os-windows arch-x64 runtime-coreclr specific to the CoreCLR runtime needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Nov 19, 2024
@jkotas jkotas added area-Diagnostics-coreclr and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Nov 20, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

@tommcdon tommcdon added this to the 10.0.0 milestone Nov 25, 2024
@tommcdon tommcdon removed the untriaged New issue has not been triaged by the area owner label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@noahfalk noahfalk

@LoopedBard3 LoopedBard3

Labels
arch-x64 area-Diagnostics-coreclr os-windows runtime-coreclr specific to the CoreCLR runtime tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark
Projects
None yet
Milestone
10.0.0
Development

No branches or pull requests
4 participants
@noahfalk @jkotas @tommcdon @LoopedBard3