Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf] Windows/x64: System.Collections.TryGetValueTrue<BigStruct, BigStruct> Regression on 11/21/2024 6:45:46 PM #110191

Open
performanceautofiler bot opened this issue Nov 26, 2024 · 3 comments
Assignees
Labels
arch-x64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI os-windows runtime-coreclr specific to the CoreCLR runtime tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark
Milestone

Comments

@performanceautofiler
Copy link

Run Information

Name Value
Architecture x64
OS Windows 10.0.22631
Queue ViperWindows
Baseline 09d196184b036680d6933c8577632090ad8e34a4
Compare 975f4ea5fc9bd39141d07eb78333a0e04ac688a6
Diff Diff
Configs CompilationMode:tiered, RunKind:micro

Regressions in System.Collections.TryGetValueTrue<BigStruct, BigStruct>

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio
488.77 μs 537.39 μs 1.10 0.10 False

graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Collections.TryGetValueTrue&lt;BigStruct, BigStruct&gt;*'

System.Collections.TryGetValueTrue<BigStruct, BigStruct>.ImmutableDictionary(Size: 512)

ETL Files

Histogram

JIT Disasms

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

@performanceautofiler performanceautofiler bot added arch-x64 os-windows runtime-coreclr specific to the CoreCLR runtime untriaged New issue has not been triaged by the area owner labels Nov 26, 2024
@LoopedBard3 LoopedBard3 transferred this issue from dotnet/perf-autofiling-issues Nov 26, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Nov 26, 2024
@LoopedBard3 LoopedBard3 changed the title [Perf] Windows/x64: 1 Regression on 11/21/2024 6:45:46 PM [Perf] Windows/x64: System.Collections.TryGetValueTrue<BigStruct, BigStruct> Regression on 11/21/2024 6:45:46 PM Nov 26, 2024
@LoopedBard3 LoopedBard3 added tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark labels Nov 26, 2024
@LoopedBard3
Copy link
Member

LoopedBard3 commented Nov 26, 2024

Likely: #109987 from range: 98049e5...c31bb93. FYI: @EgorBo. We are only seeing the TryGetValueTrue regression on ViperWindows and this seems to be a newer test so may be something hardware specific or noise.

Related Regression:
Windows x64:

Linux arm64:

Windows arm64:

@jeffschwMSFT jeffschwMSFT added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Dec 3, 2024
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@vcsjones vcsjones removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Dec 3, 2024
@JulieLeeMSFT JulieLeeMSFT removed the untriaged New issue has not been triaged by the area owner label Dec 6, 2024
@JulieLeeMSFT JulieLeeMSFT added this to the 10.0.0 milestone Dec 6, 2024
@JulieLeeMSFT
Copy link
Member

@EgorBo, PTAL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch-x64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI os-windows runtime-coreclr specific to the CoreCLR runtime tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark
Projects
None yet
Development

No branches or pull requests

5 participants