Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf] Windows/x64: 1 Regression on 11/18/2024 8:23:46 PM #110193

Closed
performanceautofiler bot opened this issue Nov 26, 2024 · 2 comments
Closed

[Perf] Windows/x64: 1 Regression on 11/18/2024 8:23:46 PM #110193

performanceautofiler bot opened this issue Nov 26, 2024 · 2 comments
Labels
arch-x64 needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners os-windows runtime-coreclr specific to the CoreCLR runtime tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark

Comments

@performanceautofiler
Copy link

Run Information

Name Value
Architecture x64
OS Windows 10.0.22631
Queue ViperWindows
Baseline 234e2f7ec5dd315014f31574719900c0715f9477
Compare e33be4d53ab951272c9161c50b549e5e7db60262
Diff Diff
Configs CompilationMode:tiered, RunKind:micro

Regressions in System.Collections.CtorDefaultSize<String>

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio
16.33 ns 19.85 ns 1.22 0.16 False

graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Collections.CtorDefaultSize&lt;String&gt;*'

System.Collections.CtorDefaultSize<String>.Dictionary

ETL Files

Histogram

JIT Disasms

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

@performanceautofiler performanceautofiler bot added arch-x64 os-windows runtime-coreclr specific to the CoreCLR runtime untriaged New issue has not been triaged by the area owner labels Nov 26, 2024
@LoopedBard3 LoopedBard3 transferred this issue from dotnet/perf-autofiling-issues Nov 26, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Nov 26, 2024
@LoopedBard3 LoopedBard3 added tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark labels Nov 26, 2024
@LoopedBard3
Copy link
Member

Potentially: #109882 in commit range: 2c7c6bf...f3cdf14. Would the commit make sense as having caused this regression @AaronRobinsonMSFT?

@AaronRobinsonMSFT
Copy link
Member

@LoopedBard3 It is entirely possible the referenced PR contributed to this. The instantiation of the Dictionary<string, string> does have some special cased code paths, perhaps indirectly sensitive to my changes, and that could be why this is occurring there and not with other types. Regardless, this change is for simplifying and removing a troublesome code pattern in the runtime. Minor regressions like this, < 5 ns, seem reasonable for the benefit of the effort.

@dotnet-policy-service dotnet-policy-service bot removed the untriaged New issue has not been triaged by the area owner label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch-x64 needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners os-windows runtime-coreclr specific to the CoreCLR runtime tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark
Projects
None yet
Development

No branches or pull requests

2 participants