Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APX-REX2] Left-over TODOs after REX2 encoding changes #110414

Open
Ruihan-Yin opened this issue Dec 4, 2024 · 2 comments
Open

[APX-REX2] Left-over TODOs after REX2 encoding changes #110414

Ruihan-Yin opened this issue Dec 4, 2024 · 2 comments
Assignees
Labels
apx Related to the Intel Advanced Performance Extensions (APX) area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Milestone

Comments

@Ruihan-Yin
Copy link
Contributor

Ruihan-Yin commented Dec 4, 2024

With #106557, we provided the REX2 encoding functionality to JIT backend, but due to the definition for extended GP registers (REG_R16~REG_R31) is still missing, I'm opening this issue to track TODOs needed to complete when we have register allocator properly updated.

  1. revisit the temporary changes in IsExtendedGPReg, currently it simply return false in any cases, we will need to add correct EGPR checks to it.
  2. potentially, we will need to revisit the REX2 stress logic when REX2 and register allocator changes are all there, make sure the encoding stress mode is working properly.
  3. (tracked by separate issue: [X86] add missing TP and latency information for rcl_N/rcr_N #110415): add missing tp and latency information to rcl_N/rcr_N, and enable them for REX2.
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Dec 4, 2024
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Dec 4, 2024
@teo-tsirpanis teo-tsirpanis added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI apx Related to the Intel Advanced Performance Extensions (APX) and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Dec 5, 2024
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@JulieLeeMSFT JulieLeeMSFT removed the untriaged New issue has not been triaged by the area owner label Dec 6, 2024
@JulieLeeMSFT JulieLeeMSFT added this to the 10.0.0 milestone Dec 6, 2024
@JulieLeeMSFT
Copy link
Member

Assigned to @Ruihan-Yin for now, but we can redistribute as needed.
CC @BruceForstall, @tannergooding, and @anthonycanino.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apx Related to the Intel Advanced Performance Extensions (APX) area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

No branches or pull requests

3 participants