-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mono][aot] Static virtual interface methods do not work with generic sharing #54910
Comments
I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label. |
If these aren't going to work do we need to flag them for AOT for 6? cc @marek-safar |
We discussed that with @lambdageek and we could not compile the managed APIs for browser-wasm |
I assume that means the work to skip them is targeted for 6.0.0 though? |
Should be fixed by: |
* Pin MicrosoftNetCompilersToolsetVersion to a version that supports Static Abstracts in Interfaces * Fixed issues related to enabling generic math in a general sense (#4) - Disable constraint checking during EEInit - Disable il linker running on CoreLib - Fixup generic math tests to actually build * Adding interfaces to support generic math * Implement generic math interfaces on core types * Updating the System.Runtime ref assembly to support generic math * Add a basic xunit test for generic-math * Removing unnecessary nullable annotations * Ensure all preview interface members are explicitly implemented * Don't use var for various methods in Double/Half/Single * Ensure FeatureGenericMath is defined for Mono * Skip generic math tests on Mono WASM due to #54910 * Apply suggestions from code review Co-authored-by: Aleksey Kliger (λgeek) <akliger@gmail.com> Co-authored-by: David Wrighton <davidwr@microsoft.com> Co-authored-by: Aleksey Kliger (λgeek) <akliger@gmail.com>
This is still an ActiveIssue on some tests.
|
…traints. If a generic argument is a primitive type, and it has an interface constraint that enums don't implement, then partial sharing for that instance is not useful, since only the specific primitive type instance will be able to use the shared version. Fixes dotnet#54910.
Related to #49904
The new tests added in #54650 do not work on the WebAssembly AOT lanes.
Stack traces look like this:
https://gist.github.com/lambdageek/eed2cbb34c6c133a29b0429c84e0365b
The text was updated successfully, but these errors were encountered: